463952 - Table row background repeat-x problem

Status: VERIFIED FIXED

(Core :: Layout: Images, Video, and HTML Frames, defect, P2)

Description

[Paweł Kondzior]

User-Agent:       Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b2pre) Gecko/20081109 Minefield/3.1b2pre
Build Identifier: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b2pre) Gecko/20081109 Minefield/3.1b2pre

Firefox Nighlty Builds after 2008-11-04 draw incorrect background for table rows when repeat-x is set. Only first table is having proper repeating, all other columns will be white, without background.

Reproducible: Always

Comment 1

[Paweł Kondzior]

Attachment: testcase

Comment 2

[philippe (part-time)]

http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=fbae114d6133&tochange=dcec193ba5d7

probably Bug 458487

I see the background behind 2 table-cells, btw

Comment 3

[Alex]

There are some issues with zooming the testcase, it'll start drawing in other cells then stop again depending on the level.

One thing that is consistent, is that it doesn't draw in all of them.

Comment 4

[Paweł Kondzior]

If image will be only width pixel height it will draw only in one cell. Right now after zooming it draws in more cells only in more than one cell because it is pretty wide image.

This is example with wrong draw of background in current nightly:
http://mt15.quickshareit.com/share/picture7a8b86.png

And this is before 2008-11-04
http://mt13.quickshareit.com/share/picture9716e4.png

Comment 5

[Richard Fuller]

I'm seeing this problem with the latest nightlies. If a column begins after the point the image repeats that column does not get the background. Making my background image wider than the whole table works around the issue, with a 1px wide image only the first column ever gets the image.

Comment 6

[Richard Fuller]

Sorry, should have said this is on Linux:
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1b2pre) Gecko/20081110 Minefield/3.1b2pre

Comment 7

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: fix

The problem is that aBGClipArea is set and is outside the original image tile; taking the intersection of the destRect and bgClipArea gives us an empty rect with strange coordinates. We need to first expand the rect according to repeat-x/y, then take the intersection.

Comment 8

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Comment on attachment 347710 [details] [diff] [review]
fix

r+sr=dbaron

Comment 9

[Paweł Kondzior]

When it will land ?

Comment 10

[Robert O'Callahan (:roc) (email my personal email if necessary)]

After beta2, before 3.1 final.

Comment 11

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Landed on mozilla-central (and thus also on mozilla-1.9.1):
http://hg.mozilla.org/mozilla-central/rev/b45e6263d385

Comment 14

[Aaron Train [:aaronmt]]

Verified fixed 1.9.1 in Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1pre) Gecko/20090526 Shiretoko/3.5pre & Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2a1pre) Gecko/20090526 Minefield/3.6a1pre