Closed Bug 464052 Opened 17 years ago Closed 17 years ago

windows compilers don't like variables named far

Categories

(Core :: JavaScript Engine, defect)

Product:
Core
Component:
JavaScript Engine
Platform:
x86
Windows XP
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: blassey, Unassigned)

Details

(Keywords: fixed1.9.1, mobile)

Attachments

(1 file)

comments out the far parameter name
891 bytes, patch
crowderbt
: review+
sayrer
: approval1.9.1+
Details | Diff | Splinter Review
this has already been fixed on x86 (http://hg.mozilla.org/mozilla-central/rev/5712af41e204) , but its even easier on arm since we don't use the variable.
Attachment #347300 - Flags: review? → review?(crowder)
Attachment #347300 - Attachment is patch: true
Attachment #347300 - Attachment mime type: application/octet-stream → text/plain
Comment on attachment 347300 [details] [diff] [review] comments out the far parameter name Please follow up with dvander on #jsapi or gal (also on #jsapi) about whether or not this parameter should be removed entirely.
Attachment #347300 - Flags: review?(crowder) → review+
http://hg.mozilla.org/mozilla-central/rev/647bcc51b244
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Flags: in-testsuite-
Flags: in-litmus-
Attachment #347300 - Flags: approval1.9.1?
Attachment #347300 - Flags: approval1.9.1? → approval1.9.1+
Keywords: fixed1.9.1
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: