Closed Bug 464091 Opened 16 years ago Closed 16 years ago

Modify windows widget to work for windows ce

Categories

(Core :: Widget: Win32, defect, P4)

Product:
Core
Component:
Widget: Win32
Platform:
ARM
Windows CE
Type:
defect

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: blassey, Assigned: dougt)

Details

(Keywords: fixed1.9.1, mobile)

Attachments

(3 files, 5 obsolete files)

patch v.5
55.12 KB, patch
emaijala+moz
: review+
pavlov
: superreview+
Details | Diff | Splinter Review
merged - ready for landing.
54.06 KB, patch
Details | Diff | Splinter Review
patch for 191 (merged)
86.98 KB, patch
Details | Diff | Splinter Review 
      No description provided.
Assignee: nobody → doug.turner
Attached patch patch v.1 (obsolete) — — Splinter Review 
a much cleaned up version of the hacky patch.
Attachment #347686 - Flags: review?
Comment on attachment 347686 [details] [diff] [review]
patch v.1

I moved some of the non-required components (like clipboard) out of the build for wince.  We can address these separately later.

Much of the rest of the patch is adjusting old wince #define
Attachment #347686 - Flags: review? → review?(emaijala)
Attached patch patch v.2 (obsolete) — — Splinter Review 
emaijala, i enabled WM_ printing in this patch.  of course, we should turn that off.  Otherwise, i would love some feedback here.

The #ifdef removal is because we are no longer building those files.  If we decide later that that we need to compile these files, we should readdress this issue.
Attachment #347357 - Attachment is obsolete: true
Attachment #347686 - Attachment is obsolete: true
Attachment #348221 - Flags: review?(emaijala)
Attachment #347686 - Flags: review?(emaijala)
Attached patch patch v.3 (obsolete) — — Splinter Review 

        Attachment #348221 -
        Attachment is obsolete: true

        Attachment #348586 -
        Flags: review?(emaijala)

        Attachment #348221 -
        Flags: review?(emaijala)

    
    

    
  
please ignore the change to dom/src/base/nsGlobalWindow.cpp.

    
    

    
  
Comment on attachment 348586 [details] [diff] [review]
patch v.3

+  if ( !mWnd )
+    *aState = PR_TRUE;
+  else if ( !::IsWindowEnabled(mWnd) )
+    *aState = PR_FALSE;

aState is not being set if mWnd is defined and IsWindowEnabled() returns true.

With that fixed, r=me.

        Attachment #348586 -
        Flags: review?(emaijala) → review+

    
    

    
  

      
      
      
      

        Attached patch
          
          
        patch v.4 (obsolete)
        — 
          — Splinter Review
      

    


  
same as last patch, but I added back some of the wince stuff (like the software keyboard support)

        Attachment #348586 -
        Attachment is obsolete: true

        Attachment #351503 -
        Flags: superreview?(pavlov)

        Attachment #351503 -
        Flags: review?(emaijala)

    
  

        Attachment #351503 -
        Flags: review?(emaijala) → review-

    
    

    
  
Comment on attachment 351503 [details] [diff] [review]
patch v.4

The patch doesn't apply cleanly so I can't verify it although it looks fine.

    
    

    
  

      
      
      
      

        Attached patch
          
          
        patch v.5
        — 
          — Splinter Review
      

    


  
similar to v.4, but I did not try to reorder the cases in ProcessMessage.  We can do that work in a different bug. (468365)

        Attachment #351503 -
        Attachment is obsolete: true

        Attachment #351814 -
        Flags: review?(emaijala)

        Attachment #351503 -
        Flags: superreview?(pavlov)

    
  

        Attachment #351814 -
        Flags: review?(emaijala) → review+

    
  

        Attachment #351814 -
        Flags: superreview+

    
    

    
  
2fb17425c988

    
    

    
  
fennec on wince will not build without this change.
Flags: blocking1.9.1?
Flags: blocking-fennec1.0?

    
    

    
  
lets bake for a few days before landing this on 1.9.1
Flags: blocking1.9.1? → blocking1.9.1+
Priority: -- → P4

    
    

    
  
in comment #12, 2fb17425c988 referred to mozilla-central.

    
    

    
  


  

    
    

    
  
Comment on attachment 355419 [details] [diff] [review]
merged - ready for landing.

>+#ifndef WINCE
>+HKL nsWindow::gKeyboardLayout = 0;
>+#endif

>+  static HKL    gKeyboardLayout;

These are removed by bug 424663 and not used at all even on desktop Windows. Why did you add them again?

    
    

    
  
unintentional.  I pushed a change to remove these two references.  mc:04332a026eb3

    
    

    
  
1.9.1 - f5ddd930e354
Keywords: fixed1.9.1

    
    

    
  
unintentional change pointed out by emk: 1.9.1 - e4c67935689c

    
    

    
  
resolving fixed.  this has landed on 1.9.1 and mc
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED

    
    

    
  
landed on 1.9.1, removing blocking-fennec request
Flags: blocking-fennec1.0?

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: