Closed Bug 464091 Opened 11 years ago Closed 11 years ago
Modify windows widget to work for windows ce
No description provided.
Assignee: nobody → doug.turner
a much cleaned up version of the hacky patch.
Attachment #347686 - Flags: review?
Comment on attachment 347686 [details] [diff] [review] patch v.1 I moved some of the non-required components (like clipboard) out of the build for wince. We can address these separately later. Much of the rest of the patch is adjusting old wince #define
Attachment #347686 - Flags: review? → review?(emaijala)
emaijala, i enabled WM_ printing in this patch. of course, we should turn that off. Otherwise, i would love some feedback here. The #ifdef removal is because we are no longer building those files. If we decide later that that we need to compile these files, we should readdress this issue.
please ignore the change to dom/src/base/nsGlobalWindow.cpp.
Comment on attachment 348586 [details] [diff] [review] patch v.3 + if ( !mWnd ) + *aState = PR_TRUE; + else if ( !::IsWindowEnabled(mWnd) ) + *aState = PR_FALSE; aState is not being set if mWnd is defined and IsWindowEnabled() returns true. With that fixed, r=me.
Attachment #348586 - Flags: review?(emaijala) → review+
same as last patch, but I added back some of the wince stuff (like the software keyboard support)
Comment on attachment 351503 [details] [diff] [review] patch v.4 The patch doesn't apply cleanly so I can't verify it although it looks fine.
similar to v.4, but I did not try to reorder the cases in ProcessMessage. We can do that work in a different bug. (468365)
fennec on wince will not build without this change.
lets bake for a few days before landing this on 1.9.1
Flags: blocking1.9.1? → blocking1.9.1+
Priority: -- → P4
in comment #12, 2fb17425c988 referred to mozilla-central.
Comment on attachment 355419 [details] [diff] [review] merged - ready for landing. >+#ifndef WINCE >+HKL nsWindow::gKeyboardLayout = 0; >+#endif >+ static HKL gKeyboardLayout; These are removed by bug 424663 and not used at all even on desktop Windows. Why did you add them again?
unintentional. I pushed a change to remove these two references. mc:04332a026eb3
1.9.1 - f5ddd930e354
unintentional change pointed out by emk: 1.9.1 - e4c67935689c
resolving fixed. this has landed on 1.9.1 and mc
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
landed on 1.9.1, removing blocking-fennec request
You need to log in before you can comment on or make changes to this bug.