Created attachment 347460 [details] [diff] [review] uses int instead of INT_PTR I assume there's a reason we use INT_PTR, what is it?
Attachment #347460 - Flags: review?
Attachment #347460 - Flags: review? → review?(crowder)
Comment on attachment 347460 [details] [diff] [review] uses int instead of INT_PTR Would like dvander to look, too.
10 years ago
Attachment #347460 - Flags: review?(danderson) → review+
The only reason I can think of is VS2k5 had a /Wp64 flag that would whine if you didn't use certain types when casting with pointers -- it should be safe here.
Attachment #347460 - Flags: approval1.9.1?
Duplicate of this bug: 456472
Did this get checked in (rather, should this bug be resolved)? It should be fine, but the WINCE SDK (both WINCE and Windows Mobile 6) all have: typedef int INT_PTR, *PINT_PTR; So this could just be a missing #include. Patch is fine either way though, no need for the #include just for that one int.
crowder has this been fixed to your satisfaction?
It must've been, since we're building without a patch queue, right?
we are, but the patch on this bug didn't land and I thought I heard you talking to about this bug with someone (wolfe?)
This code is gone from nanojit, so there's nothing to patch looks like..
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.