INT_PTR not defined on wince

RESOLVED INVALID

Status

()

Core
JavaScript Engine
RESOLVED INVALID
10 years ago
9 years ago

People

(Reporter: blassey, Unassigned)

Tracking

({mobile})

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Comment hidden (empty)
(Reporter)

Comment 1

10 years ago
Created attachment 347460 [details] [diff] [review]
uses int instead of INT_PTR

I assume there's a reason we use INT_PTR, what is it?
Attachment #347460 - Flags: review?
(Reporter)

Updated

10 years ago
Attachment #347460 - Attachment is patch: true
Attachment #347460 - Attachment mime type: application/octet-stream → text/plain
(Reporter)

Updated

10 years ago
Attachment #347460 - Flags: review? → review?(crowder)

Comment 2

10 years ago
Comment on attachment 347460 [details] [diff] [review]
uses int instead of INT_PTR

Would like dvander to look, too.
Attachment #347460 - Flags: review?(danderson)
Attachment #347460 - Flags: review?(crowder)
Attachment #347460 - Flags: review+
Attachment #347460 - Flags: review?(danderson) → review+
The only reason I can think of is VS2k5 had a /Wp64 flag that would whine if you didn't use certain types when casting with pointers -- it should be safe here.
(Reporter)

Updated

10 years ago
Attachment #347460 - Flags: approval1.9.1?

Updated

10 years ago
Attachment #347460 - Flags: approval1.9.1? → approval1.9.1+
Did this get checked in (rather, should this bug be resolved)?  It should be fine, but the WINCE SDK (both WINCE and Windows Mobile 6) all have:

  typedef int INT_PTR, *PINT_PTR;

So this could just be a missing #include.  Patch is fine either way though, no need for the #include just for that one int.
crowder has this been fixed to your satisfaction?

Comment 7

9 years ago
It must've been, since we're building without a patch queue, right?
we are, but the patch on this bug didn't land and I thought I heard you talking to about this bug with someone (wolfe?)
This code is gone from nanojit, so there's nothing to patch looks like..

Updated

9 years ago
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → INVALID

Updated

9 years ago
Attachment #347460 - Flags: approval1.9.1+
You need to log in before you can comment on or make changes to this bug.