[FIX] Crash [@ nsMediaDecoder::Progress]

VERIFIED FIXED in mozilla1.9.2a1

Status

()

--
critical
VERIFIED FIXED
10 years ago
7 years ago

People

(Reporter: jruderman, Assigned: smaug)

Tracking

(Blocks: 1 bug, {crash, testcase, verified1.9.1})

Trunk
mozilla1.9.2a1
crash, testcase, verified1.9.1
Points:
---
Bug Flags:
blocking1.9.1 +
wanted1.9.0.x -
wanted1.8.1.x -
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [sg:critical], crash signature)

Attachments

(2 attachments)

(Reporter)

Description

10 years ago
Created attachment 347479 [details]
testcase (crashes Firefox within a few seconds)

Example stack #1:

0   nsINodeInfo::GetDocument() const + 9 (nsINodeInfo.h:291)
1   nsINode::GetOwnerDoc() const + 28 (nsINode.h:268)
2   nsHTMLMediaElement::DispatchProgressEvent(nsAString_internal const&) + 64 (nsHTMLMediaElement.cpp:813)
3   nsMediaDecoder::Progress() + 73 (nsMediaDecoder.cpp:138)
4   ProgressCallback(nsITimer*, void*) + 30
5   nsTimerImpl::Fire() + 868 (nsTimerImpl.cpp:421)
...

Example stack #2:

0   0 + 3968030437
1   nsMediaDecoder::Progress() + 73 (nsMediaDecoder.cpp:138)
2   ProgressCallback(nsITimer*, void*) + 30
3   nsTimerImpl::Fire() + 868 (nsTimerImpl.cpp:421)
...

Note that nsMediaDecoder::Progress appears in both stacks.
Flags: blocking1.9.1?
(Reporter)

Updated

10 years ago
Whiteboard: [sg:critical]
Created attachment 347585 [details] [diff] [review]
remember to shutdown decoder before nulling the variable
Assignee: nobody → Olli.Pettay
Status: NEW → ASSIGNED
Attachment #347585 - Flags: superreview?(roc)
Attachment #347585 - Flags: review?(roc)
Attachment #347585 - Flags: superreview?(roc)
Attachment #347585 - Flags: superreview+
Attachment #347585 - Flags: review?(roc)
Attachment #347585 - Flags: review+
Keywords: checkin-needed
Summary: Crash [@ nsMediaDecoder::Progress] → [FIX] Crash [@ nsMediaDecoder::Progress]
Flags: blocking1.9.1? → blocking1.9.1+
You don't need approval, since this is a blocker now.
Whiteboard: [sg:critical] → [sg:critical][needs landing]
Comment on attachment 347585 [details] [diff] [review]
remember to shutdown decoder before nulling the variable

Ok.
Attachment #347585 - Flags: approval1.9.1?
Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
Whiteboard: [sg:critical][needs landing] → [sg:critical]
Keywords: fixed1.9.1
Keywords: checkin-needed

Comment 4

10 years ago
Verified fix on Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2a1pre) Gecko/20090204 Minefield/3.2a1pre
and Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b3pre) Gecko/20090204 Shiretoko/3.1b3pre Ubiquity/0.1.5
Status: RESOLVED → VERIFIED
Keywords: fixed1.9.1 → verified1.9.1
Flags: in-testsuite?
OS: Mac OS X → All
Hardware: x86 → All
Target Milestone: --- → mozilla1.9.2a1
Flags: wanted1.9.0.x-
Flags: wanted1.8.1.x-
Group: core-security
(Reporter)

Comment 5

9 years ago
Crashtest: http://hg.mozilla.org/mozilla-central/rev/c38d6ec28c45
Flags: in-testsuite? → in-testsuite+
Crash Signature: [@ nsMediaDecoder::Progress]
You need to log in before you can comment on or make changes to this bug.