46420 - NSS port for OS/2

Status: VERIFIED FIXED

(NSS :: Tools, defect, P3)

Description

[Huynh Trinh]

Via this bug, we will submit build/makefile/code changes required to 
build NSS for OS/2, in both gcc/emx and VACPP builds.

Comment 1

[Wan-Teh Chang]

Huynh, please use the "Create a new attachment"
link in the bug report to attach your patch and
we will review and test it.  Thanks.

Comment 2

[Huynh Trinh]

Wan-Teh, thanks for responding so soon.
One of the changes  consists of replacing the explicit .a suffix to 
$(LIB_SUFFIX) in the makefiles. 
Do I have to submit individual diff for each makefile or can someone 
with check-in right do a global change to the following makefiles:

- security/nss/lib/fortcrypt/swfort/pkcs11
- security/nss/cmd
- security/nss/cmd/swfort
- security/nss/cmd/swfort/newuser
- security/nss/cmd/signtool
- security/nss/cmd/pk12util
- security/nss/cmd/crmftest
- security/nss/cmd/crmf.cgi

Comment 3

[Huynh Trinh]

Attachment: Batch01 - Changes .a to .$(LIB_SUFFIX) in NSS Makefiles

Comment 4

[snizinsk]

corrected spelling of "port" in summary line

Comment 5

[Wan-Teh Chang]

The patch is fine -- I assume you will add mozilla/security/coreconf/OS2.mk?

Comment 6

[Huynh Trinh]

Yes, I have a prelim versin of os2.mk whicj I will submit shortly.

Comment 7

[Mike Kaply [:mkaply]]

Do you want us to check these in?

If so, what branch/etc.

Thanks

Comment 8

[Wan-Teh Chang]

We should check these in so that they get
checked into the tip and the appropriate
branches.

Could you attach your OS2.mk file?

Bob, could you check these in?  I've already
reviewed their patches, so you just need to
review OS2.mk.  Thanks.

Comment 9

[Huynh Trinh]

Attachment: Batch02 - OS2.mk (preleminary version .01?)

Comment 10

[Huynh Trinh]

I attached a preliminary version of OS2.mk per your request. I am 
expecting the BSAFE source code soon and will submit additional build 
related changes to OS2.mk and other other files very soon.

Comment 11

[Huynh Trinh]

Attachment: Batch03 - OS2 changes for arch.mk and suffix.mk

Comment 12

[Robert Relyea]

Yes, I can check it in.

bob

Comment 13

[Huynh Trinh]

Attachment: BATCH04- Update os2_rand.c and associated manifest.mn

Comment 14

[Huynh Trinh]

Attachment: Batch05 - Use $(LIB_SUFFIX) in platlibs.mk

Comment 15

[Huynh Trinh]

Attachment: Batch06- Updates for OS/2 (secport.c, swfutl.c, gpkmem.h)

Comment 16

[Huynh Trinh]

Bob; Your comment on 8/17 indicates that you will check-in the changes 
for Batch 01,02,03. I would appreciate if you could append a note 
saying that the check-in is done. Thanks.

Wan-teh; Could you please review attached Batch04, 05. Thanks.

Comment 17

[Huynh Trinh]

Attachment: Batch07- Add nss/lib/ssl/os2_err.c for OS/2

Comment 18

[Huynh Trinh]

Attachment: Batch08 - Add nss/lib/ssl/os2_err.h for OS2

Comment 19

[Huynh Trinh]

Attachment: Batch09 - Update nss/lib/ssl/Makefile

Comment 20

[Huynh Trinh]

Attachment: Batch10 - nss/cmd/certutil/keystuff.c

Comment 21

[Huynh Trinh]

Attachment: Latest os2.mk. This version replaces Batch02

Comment 22

[Robert Relyea]

OK, this code is checked into the NSS_30_BRANCH. Please verify that it all still 
works for OS/2. I merged the files in by hand.

I'll be merging the changes into the tip this morning...

Comment 23

[Robert Relyea]

patches are now in on both the tip and the branch.

Comment 24

[Mike Kaply [:mkaply]]

Verified changes are in