464222 - Relative links not linkified in "View Selection Source"

Status: RESOLVED FIXED

(Core :: DOM: HTML Parser, enhancement)

Description

[PikeUK]

Steps to Reproduce:
1. Highlight a relative link on a page.
2. On context menu go to "View Selection Source".

Only absolute links are linkified in selection/DOM source, whereas all links are linkified in normal view source.

Using:
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b2pre) Gecko/20081110 Minefield/3.1b2pre

Comment 1

[Johnathan Nightingale [:johnath]]

Note to would-be implementors, if they aren't named Curtis: See bug 17612 for original implementation of source linking.  :)

Comment 2

[James Kitchener (:jkitch)]

Attachment: Part 1: protocol changes

Stores baseURI within nsIViewSourceChannels for use in non-srcdoc documents.

Nothing terribly exciting.

Comment 3

[James Kitchener (:jkitch)]

Attachment: Part2: WebNavigation Changes

This adds a new method to nsIWebNavigation to allow a loadURI variant with an extra argument.  (The existing loadURI is used in too many places to consider changing it).

I've tried to make it clear within the interface comments that the new method will only differ in specific situations (namely view-source: URIs and then only some of the time).  Any other possible behaviour is unimplemented.

Comment 4

[James Kitchener (:jkitch)]

Attachment: Part 3: parser changes

We now check every (view-source) channel for presence of baseURI, before falling back to the old method.  This gives the data URIs of view selection source an awareness 

In principle, non-srcdoc, non-selection channels will also use the channel baseURI rather than the fallback method.  But this requires a deliberate choice to implement the appropriate codepaths to enable ir.

Comment 5

[James Kitchener (:jkitch)]

Attachment: Part 4: toolkit changes and test

This passes a base URI to a variant of the webnav LoadURI function to allow relative URIs to work in view selection source.

Comment 6

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8372993 [details] [diff] [review]
Part 1: protocol changes

> Returns a nullptr when it isn't set or isn't a

s/a nullptr/null/

r=me

Comment 7

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8372994 [details] [diff] [review]
Part2: WebNavigation Changes

This seems like it might better go on the settings object bug 965413 will add.  Maybe file a followup to consider moving it there once that bug lands?

Comment 8

[James Kitchener (:jkitch)]

Attachment: Part 1: protocol changes

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f0412d2e262c
https://hg.mozilla.org/integration/mozilla-inbound/rev/af8283de5112
https://hg.mozilla.org/integration/mozilla-inbound/rev/08ed6226573d
https://hg.mozilla.org/integration/mozilla-inbound/rev/3ad497d0c250

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/f0412d2e262c
https://hg.mozilla.org/mozilla-central/rev/af8283de5112
https://hg.mozilla.org/mozilla-central/rev/08ed6226573d
https://hg.mozilla.org/mozilla-central/rev/3ad497d0c250