46435 - saved .hqx files are owned by mozilla

Status: RESOLVED FIXED

(SeaMonkey :: UI Design, defect, P3)

Description

[Warren Harris]

If you download a .hqx file, it's creator ends up being mozilla instead of 
stuffit.

Comment 1

[Adam]

This is indicitave of a MUCH larger bug - Mozilla can't handle Mac OS
creator/file types at all. Any file you download will be saved with the creator
"MOSS" and file type "????" - defeating the whole purpose of creator/file types.

Comment 2

[Bill Law]

This is file download related bug Mac-specific.  Nominating and passing over to
Paul.

Comment 3

[Simon Fraser [no longer active]]

Sounds like it would be fixed by an exception list in the nsLocalFileMac type/
creator setting. Cc conrad

Comment 4

[Paul Chen]

Isn't this a dupe of 55891, which got checked into the trunk on 11-14 by ccarlen?

Comment 5

[Conrad Carlen (not reading bugmail)]

No, it's not a dup. This problem was just changed by the checkin for bug 55891.
Before most files got saved with with creator 'MOSS' and type '????'. The fix to
bug 55891 made the creator be that of the current process and the type be looked
up from IC. Simon's right. This needs to be improved with some exception list. I
think the type should always be looked up from IC as it is now and the creator
should usually be looked up from IC except certain types. We just need to decide
what those types are.

Comment 6

[Simon Fraser [no longer active]]

Almost anything that's in IC I think we don't want to give a MOSS creator type, 
with the exception of 'TEXT' files. So use IC creators for everything except 
'TEXT', and file types that are in our BNDL resource.

Comment 7

[Conrad Carlen (not reading bugmail)]

Basing it on what's in the BNDL sounds good. pchen, you can give this to me if
you want.

Comment 8

[Andrew Thompson]

Ultimately Moz should respect Internet Config for creators and types.

I guess there might be specific exceptions like creator: MOZZ  type: TEXT but then:

* that has nothing to do with this bug - Moz should just use the IC setting for
hq files

* even if we were thinking about that case - shouldn't we respect the user's
desires in all cases?

e.g. what should type: "HTML" be - should it not be creator == whatever Internet
Config says it is?

If the user's preferred browser  isn't mozilla, why should moz own TEXT or HTML
files? That's what moz's "should I be preferred broswer" prefs are for...

I think only TEXT is a special case.

Comment 9

[Paul Chen]

nav triage team:

Marking nsbeta1+, mozilla0.8

Comment 10

[selmer (gone)]

We're past time to cut these low priority bugs from mozilla0.8.  Please update
these bugs today. 

Comment 11

[Paul Chen]

Attachment: diff to nsLocalFileMac.cpp

Comment 12

[Paul Chen]

Attachment: diff to nsLocalFileMac.h

Comment 13

[Paul Chen]

So the fix involves a) setting mac file creator along with file type in what used 
to be SetOSTypeFromExtension(), which has now been renamed to 
SetOSTypeAndCreatorFromExtension(), b) creating a new method 
ExtensionIsOnExceptionList() which returns PR_TRUE when a file extension is on 
the exception list, and c) calling ExtensionIsOnExceptionList() from within 
SetOSTypeAndCreatorFromExtension()

Comment 14

[Simon Fraser [no longer active]]

Comments: the exception list is based on file extension (which may not be 
present). Why not base it on the file type which you've just found out, rather 
than the extension? Basing it on file type has the advandate that (at some later 
stage) we could grovel in the BNDL resource for 'owned file types'. And it's 
cheaper to compare 4-char codes than strings.

Not your code bug...
        extPtr = const_cast<char *>(extension); // really, we won't touch it
why not declare 'extPtr' as a const char* to begin with?

Comment 15

[Paul Chen]

Attachment: new version of nsLocalFileMac.cpp with '!' in front of nsCRT:strcasecmp calls

Comment 16

[Paul Chen]

Attachment: latest patch of nsLocalFileMac.cpp, remove the const_cast

Comment 17

[Simon Fraser [no longer active]]

sr=sfraser on the patch

Comment 18

[Paul Chen]

Since I promised storage closet time with him and hyatt, r=pinkerton. Oh yeah, 
he thinks the code is okay, too.

Comment 19

[Paul Chen]

Stick a fork in it, checked into tree