464353 - [10.6] Upside down checkmarks

Status: VERIFIED FIXED

(Core :: Widget: Cocoa, defect)

Description

[Marcia Knous [:marcia]]

Attachment: Screenshot of Import dialog

Seen while running Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en-US; rv:1.9.1b2pre) Gecko/20081111 Minefield/3.1b2pre. This bug is being filed to track an Apple bug.

STR:

1. File | Import
2. Import from Safari
3. Observe attached screenshot

Comment 1

[Marcia Knous [:marcia]]

Attachment: Also happens in preferences

Comment 2

[Josh Aas]

This needs to be investigated early in case we need Apple to fix a bug.

Comment 3

[Steven Michaud [:smichaud] (Retired)]

This doesn't happen in Firefox 3.0.3, and I've found a regression
range:

firefox-10-13-02-mozilla-central
firefox-10-14-02-mozilla-central

http://hg.mozilla.org/mozilla-central/pushloghtml?startdate=2008-10-13+00%3A00%3A00&enddate=2008-10-14+05%3A31%3A00

Markus' patch for bug 394892 is in this range, so I think it's very
likely to have triggered this bug ... which (on the face of it) seems
likely to be an Apple bug.

Markus, do you have access to a copy of SnowLeopard?  It's now
available on ADC (to those with at least a Select membership).  It
should also be possible to get a copy from Josh.

In any case I'll keep digging, since (I think) it shouldn't be too
hard to find the trigger.

Comment 4

[Markus Stange [:mstange]]

Argh. I think this happens because Apple fixed a bug...
IIRC we explicitly set up a flip transform because otherwise checkboxes would be upside down on 10.5.
I don't have a copy of 10.6 yet.

Comment 5

[Steven Michaud [:smichaud] (Retired)]

Attachment: Possible fix

Here's a patch that seems to fix this problem.

That it works seems to confirm what Markus says in comment #4 -- Apple
appears to have fixed a bug in SnowLeopard that we previously had to
work around (in Leopard).

But there are *lots* of other places where we use (vertical) flip
transforms in nsNativeThemeCocoa.mm, and where they still seem to be
needed.  Though it's a bit hard to tell -- buttons and scrollbars and
the like are (aside from the text) usually vertically symmetrical.

Markus:  Are the other places we use flip transforms in
nsNativeThemeCocoa.mm also (in effect) workarounds for Apple bugs?  If
so, should we try to get one or more of them fixed in SnowLeopard?
That is, is it worth our while to isolate them and report them to
Apple as bugs?  The fewer distinct bugs there are (and the fewer bug
reports we'd have to open with Apple), the more "economical" it would
be to report them to (and, presumably, the more likely Apple'd be
willing to fix them).

Comment 6

[Steven Michaud [:smichaud] (Retired)]

Here's a tryserver build made with my patch from comment #5:

https://build.mozilla.org/tryserver-builds/2008-11-12_13:[e-mail]-bugzilla464353/[e-mail]

Marcia, please bang away on it and let us know what you think.

Comment 7

[Markus Stange [:mstange]]

Steven, before I review your patch, I'll write a small testing app that tests all kinds of ways of NSCell drawing. We really need to know what triggers drawing problems on which OS versions, especially since I'll change a lot of the drawing stuff in bug 450800.

Comment 8

[Steven Michaud [:smichaud] (Retired)]

Sounds good to me, Markus.

Comment 9

[Marcia Knous [:marcia]]

The build in Comment 6 resolves the issues I was seeing both in Import and Preferences with the upside down checkmarks. The world has now been righted...

Comment 10

[Markus Stange [:mstange]]

My patch in bug 450800 also fixes this bug.

Comment 11

[Steven Michaud [:smichaud] (Retired)]

Comment on attachment 347842 [details] [diff] [review]
Possible fix

(In reply to comment #10)

On the strength of this comment, and of the continuing work in bug
450800 and bug 465069, I'm marking my patch obsolete.

Comment 12

[Markus Stange [:mstange]]

Should be fixed by bug 450800.

Comment 13

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Marcia, could you please check if everything is ok on Snow Leopard? Thanks.

Comment 14

[Marcia Knous [:marcia]]

I can check, but will do so when I get a new seed which hopefully should be soon.

Comment 15

[Marcia Knous [:marcia]]

verified fixed on the 1.9.1 branch using Mac OS X 10.6 (10A261) and Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en-US; rv:1.9.1b3pre) Gecko/20090208 Shiretoko/3.1b3pre.

Comment 16

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Verified fixed on trunk with Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en-US; rv:1.9.2a1pre) Gecko/20090209 Minefield/3.2a1pre