464361 - Add support for back and forward mouse buttons to View Source

Status: RESOLVED FIXED

(Toolkit :: View Source, enhancement)

Description

[Steffen Wilberg]

Add support for back and forward mouse buttons to View Source.

The code for the main browser window is here:
http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/browser/base/content/browser.js&rev=1.1037&mark=811-839,854#811

Comment 1

[Steffen Wilberg]

Attachment: patch

Just copying some browser.js code to viewSource.js.

Comment 2

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 347657 [details] [diff] [review]
patch

>diff --git a/toolkit/components/viewsource/content/viewSource.js b/toolkit/components/viewsource/content/viewSource.js

>+  default:
>+    break;

This is rather silly, just omit it?

Comment 3

[Steffen Wilberg]

Comment on attachment 347657 [details] [diff] [review]
patch

Seeking approval for this with the two lines mentioned in comment 2 dropped.

Comment 4

[Steffen Wilberg]

Attachment: for checkin

Nit fixed, indenting added, and bracing style adjusted.

Comment 5

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 347864 [details] [diff] [review]
for checkin

a=beltzner

Comment 6

[(no longer active)]

Does this handling include Alt+Left/Right arrow keys for back/forward navigation?

Comment 7

[Curtis Bartley [:cbartley]]

(In reply to comment #6)
> Does this handling include Alt+Left/Right arrow keys for back/forward
> navigation?

Alt+Left/Right should be working already, although I didn't specifically test that.  Cmd+Left/Right do definitely work.

Comment 8

[(no longer active)]

(In reply to comment #7)
> Alt+Left/Right should be working already, although I didn't specifically test
> that.  Cmd+Left/Right do definitely work.

Yeah, they do!  Sorry for the bugspam.

Comment 9

[Steffen Wilberg]

http://hg.mozilla.org/mozilla-central/rev/7c1c494c76ee