464364 - Multiple attempts to write permission test file (should cache canUpdate)

Status: RESOLVED FIXED

(Toolkit :: Application Update, defect)

Description

[Robert Strong (they/them - no direct email)]

Attachment: patch rev1

This has been bothering me for a while and is a quick fix. This is similar to Bug 326322 except that bug claims to try to write additional files that I haven't investigated yet.

Comment 1

[Robert Strong (they/them - no direct email)]

Comment on attachment 347654 [details] [diff] [review]
patch rev1

This makes it so the write access check only one time per session. One example of why we should take this patch is that currently an attempt to create a file happens every time the Help menu is opened.

Comment 2

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 347654 [details] [diff] [review]
patch rev1

a191b2=beltzner, but won't block this milestone

Comment 3

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 347654 [details] [diff] [review]
patch rev1

We're closing down for beta 2, so we'll get this after we branch.

Comment 4

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 347654 [details] [diff] [review]
patch rev1

a191=beltzner yay for quick fixes that scratch itches!

Comment 5

[Robert Strong (they/them - no direct email)]

Attachment: bundle for checkin

Comment 6

[Shawn Wilsher :sdwilsh]

http://hg.mozilla.org/mozilla-central/rev/efa317f0470d