464485 - npruntime sample does not compile on linux (FALSE not declared)

Status: RESOLVED FIXED

(Core Graveyard :: Plug-ins, defect)

Description

[arno renevier]

Hi,
even after including npfunctions.h instead of npupp.h for npruntime, sample plugin does not compile. (see bug 464481 comment 1)

home/arno/mozilla/modules/plugin/sdk/samples/npruntime/plugin.cpp: In constructor 'CPlugin::CPlugin(NPP_t*)':
/home/arno/mozilla/modules/plugin/sdk/samples/npruntime/plugin.cpp:474: error: 'FALSE' was not declared in this scope
/home/arno/mozilla/modules/plugin/sdk/samples/npruntime/plugin.cpp: In member function 'NPBool CPlugin::init(NPWindow*)':
/home/arno/mozilla/modules/plugin/sdk/samples/npruntime/plugin.cpp:625: error: 'FALSE' was not declared in this scope
/home/arno/mozilla/modules/plugin/sdk/samples/npruntime/plugin.cpp:643: error: 'TRUE' was not declared in this scope
/home/arno/mozilla/modules/plugin/sdk/samples/npruntime/plugin.cpp: In member function 'void CPlugin::shut()':
/home/arno/mozilla/modules/plugin/sdk/samples/npruntime/plugin.cpp:655: error: 'FALSE' was not declared in this scope


I don't known if FALSE is defined on other platforms than linux, so I think that bug could be platform specific. That's why I filled a different bug.

plugin.cpp mixes false, FALSE and PR_FALSE. What about using only false ?

Comment 1

[arno renevier]

Attachment: uses false/true in lowercase

Comment 2

[Serge Gautherie (:sgautherie)]

Comment on attachment 347808 [details] [diff] [review]
uses false/true in lowercase

Removing 'checkin-needed', as a review is outstanding.

Comment 3

[arno renevier]

Comment on attachment 347808 [details] [diff] [review]
uses false/true in lowercase

Sorry, I must have been confused when reading my bugmail. I thought it has been reviewed simultaneously
 with bug #464481

Comment 4

[Josh Aas]

pushed to mozilla-central

http://hg.mozilla.org/mozilla-central/rev/32a59b44146c