There are several things that keep me up nights, but one of the worst is the fear that someone will execute removed-files, since we let it wind up with 755 perms. Slapping it with the 644 from IFLAGS1 will let me get some sleep, or at least give me more time to worry about whether the tag is still attached to my mattress.
Oh, I bet my failure to attach the patch explains why such a simple thing has sat without review for a week, doesn't it?
Better than blaming it on me!
Created attachment 348844 [details] [diff] [review] Fix Okay, *now* it's your fault. Tick. Tick.
Attachment #348844 - Flags: review?(ted.mielczarek)
Attachment #348844 - Flags: review?(ted.mielczarek) → review+
Comment on attachment 348844 [details] [diff] [review] Fix I'm just going to give you blanket r=me to change $(IFLAGS) anywhere you need to to fix permissions things like this.
Status: ASSIGNED → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
Attachment #348844 - Flags: approval1.9.1?
It's still executable: -rwxr-xr-x 1 root root 3804 11. Dez 13.26 removed-files Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.9.1b3pre) Gecko/20081211 Shredder/3.0b2pre
(In reply to comment #7) > rv:1.9.1b3pre That sounds a lot like 1.9.1 to me. I see an approval1.9.1? flag on the bug, but not any fixed1.9.1 keyword.
Comment on attachment 348844 [details] [diff] [review] Fix a191=beltzner
Attachment #348844 - Flags: approval1.9.1? → approval1.9.1+
Target Milestone: --- → mozilla1.9.1b3
You need to log in before you can comment on or make changes to this bug.