464632 - Give processed removed-files some IFLAGS lovin'

Status: RESOLVED FIXED

Description

[Phil Ringnalda (:philor)]

There are several things that keep me up nights, but one of the worst is the fear that someone will execute removed-files, since we let it wind up with 755 perms. Slapping it with the 644 from IFLAGS1 will let me get some sleep, or at least give me more time to worry about whether the tag is still attached to my mattress.

Comment 1

[Phil Ringnalda (:philor)]

Oh, I bet my failure to attach the patch explains why such a simple thing has sat without review for a week, doesn't it?

Comment 2

[Ted Mielczarek [:ted] [:ted.mielczarek]]

Better than blaming it on me!

Comment 3

[Phil Ringnalda (:philor)]

Created attachment 348844 [details] [diff] [review]
Fix

Okay, *now* it's your fault.

Tick.

Tick.

Comment 5

[Ted Mielczarek [:ted] [:ted.mielczarek]]

Comment on attachment 348844 [details] [diff] [review]
Fix

I'm just going to give you blanket r=me to change $(IFLAGS) anywhere you need to to fix permissions things like this.

Comment 6

[Phil Ringnalda (:philor)]

http://hg.mozilla.org/mozilla-central/rev/b82a593f9b52

Comment 7

[Henry N.]

It's still executable:
-rwxr-xr-x  1 root     root        3804 11. Dez 13.26 removed-files

Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.9.1b3pre) Gecko/20081211 Shredder/3.0b2pre

Comment 8

[Phil Ringnalda (:philor)]

(In reply to comment #7)
> rv:1.9.1b3pre

That sounds a lot like 1.9.1 to me. I see an approval1.9.1? flag on the bug, but not any fixed1.9.1 keyword.

Comment 9

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 348844 [details] [diff] [review]
Fix

a191=beltzner

Comment 10

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/releases/mozilla-1.9.1/rev/96c8028b34b4