Closed
Bug 464632
Opened 17 years ago
Closed 17 years ago
Give processed removed-files some IFLAGS lovin'
Categories
(Toolkit Graveyard :: Build Config, defect)
Toolkit Graveyard
Build Config
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla1.9.1b3
People
(Reporter: philor, Assigned: philor)
References
Details
(Keywords: fixed1.9.1)
Attachments
(1 file)
895 bytes,
patch
|
ted
:
review+
beltzner
:
approval1.9.1+
|
Details | Diff | Splinter Review |
There are several things that keep me up nights, but one of the worst is the fear that someone will execute removed-files, since we let it wind up with 755 perms. Slapping it with the 644 from IFLAGS1 will let me get some sleep, or at least give me more time to worry about whether the tag is still attached to my mattress.
Assignee | ||
Comment 1•17 years ago
|
||
Oh, I bet my failure to attach the patch explains why such a simple thing has sat without review for a week, doesn't it?
Comment 2•17 years ago
|
||
Better than blaming it on me!
Assignee | ||
Comment 3•17 years ago
|
||
Okay, *now* it's your fault.
Tick.
Tick.
Attachment #348844 -
Flags: review?(ted.mielczarek)
Updated•17 years ago
|
Attachment #348844 -
Flags: review?(ted.mielczarek) → review+
Comment 5•17 years ago
|
||
Comment on attachment 348844 [details] [diff] [review]
Fix
I'm just going to give you blanket r=me to change $(IFLAGS) anywhere you need to to fix permissions things like this.
Assignee | ||
Comment 6•17 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Assignee | ||
Updated•17 years ago
|
Attachment #348844 -
Flags: approval1.9.1?
It's still executable:
-rwxr-xr-x 1 root root 3804 11. Dez 13.26 removed-files
Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.9.1b3pre) Gecko/20081211 Shredder/3.0b2pre
Assignee | ||
Comment 8•17 years ago
|
||
(In reply to comment #7)
> rv:1.9.1b3pre
That sounds a lot like 1.9.1 to me. I see an approval1.9.1? flag on the bug, but not any fixed1.9.1 keyword.
Comment 9•16 years ago
|
||
Comment on attachment 348844 [details] [diff] [review]
Fix
a191=beltzner
Attachment #348844 -
Flags: approval1.9.1? → approval1.9.1+
Assignee | ||
Comment 10•16 years ago
|
||
Keywords: fixed1.9.1
Target Milestone: --- → mozilla1.9.1b3
Updated•7 years ago
|
Product: Toolkit → Toolkit Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•