Closed Bug 464751 Opened 11 years ago Closed 11 years ago

Missing button icons in Customize Toolbar dialog of Event/Task dialog

Categories

(Calendar :: Sunbird Only, defect)

defect
Not set

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: ssitter, Assigned: ssitter)

Details

(Keywords: regression)

Attachments

(1 file)

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b2pre) Gecko/20081113 Calendar/1.0pre (BuildID: 20081113032044)

Steps to Reproduce:
1. Start Sunbird with new profile
2. Open the New Event or New Task dialog
3. Right click dialog toolbar and select Customize... from context menu
4. Drag and drop the toolbar buttons back to the Customize Toolbar dialog

Actual Results:
The buttons in the Customize Toolbar dialog have no icons.

Expected Results:
The buttons in the Customize Toolbar dialog have icons.

Works in Lightning 1.0pre (20081113043141).
Assignee: nobody → ssitter
Status: NEW → ASSIGNED
Attachment #348026 - Flags: review?(philipp)
Comment on attachment 348026 [details] [diff] [review]
add missing customizeToolbar.xul overlay

I personally think we should move the toolbar related css rules into a file like calendar-event-dialog-toolbar.css to minimize the number of rules overlayed into customizeToolbar.xul, but I'm fine with going the easy route for now.

Please either add a new patch with the above considered, or set checkin-needed if you'd like to go the easy route.
Attachment #348026 - Flags: review?(philipp) → review+
I vote for a follow up bug if necessary.
Keywords: checkin-needed
Pushed to comm-central <http://hg.mozilla.org/comm-central/rev/c835317a8ff7>

-> FIXED
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Keywords: checkin-needed
OS: Windows XP → All
Hardware: PC → All
Resolution: --- → FIXED
Target Milestone: --- → 1.0
Checked in sunbird 20081130 -> VERIFIED.
Status: RESOLVED → VERIFIED
These bugs are likely targeted at Lightning 1.0b1, not Lightning 1.0. If this change was done in error, please adjust the target milestone to its correct value. To filter on this bugspam, you can use "lightning-10-target-move".
Target Milestone: 1.0 → 1.0b1
You need to log in before you can comment on or make changes to this bug.