Closed
Bug 464765
Opened 17 years ago
Closed 17 years ago
Update wizard back button displayed on Linux when it shouldn't
Categories
(Toolkit :: Application Update, defect)
Tracking
()
VERIFIED
FIXED
mozilla1.9.1b2
People
(Reporter: murali, Assigned: robert.strong.bugs)
Details
(Keywords: verified1.9.1)
Attachments
(3 files)
|
14.90 KB,
image/png
|
Details | |
|
10.15 KB,
image/png
|
Details | |
|
4.40 KB,
patch
|
mconnor
:
review+
beltzner
:
approval1.9.1b2+
|
Details | Diff | Splinter Review |
Screenshot of the result Help -> Check for updates
User-Agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9) Gecko/2008061004 Firefox/3.0 FirePHP/0.2.1
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1b2pre) Gecko/20081110 Minefield/3.1b2pre
Help->Check for Updates operation launches the update screen. On linux at the bottom right hand corner it has 2 buttons. "BACK" and "OK".
If you click "OK" the window closes.
But if you click "BACK" and subsequently click "OK" on the resulting window, the "OK" will not work.
Reproducible: Always
Steps to Reproduce:
1.Help->Check for Updates
2.Click Back button
3.Click OK button
Actual Results:
Nothing happens
Expected Results:
The window should close
|
Assignee | |
Comment 1•17 years ago
|
||
Can you provide screenshots or details to identify the first page where you click the back button and the second page where you click the ok button? Thanks
|
|
Reporter | |
Comment 2•17 years ago
|
||
|
|
Reporter | |
Comment 3•17 years ago
|
||
|
|
Reporter | |
Updated•17 years ago
|
Version: unspecified → Trunk
|
|
Assignee | |
Comment 4•17 years ago
|
||
Thanks... the back button shouldn't be displayed.
Taking
Assignee: nobody → robert.bugzilla
|
|
Reporter | |
Comment 5•17 years ago
|
||
Should I file another bug asking to remove the "Back" button !!
|
|
Assignee | |
Comment 6•17 years ago
|
||
No, removing the back button will fix this bug.
|
|
Assignee | |
Comment 7•17 years ago
|
||
Note: this is caused by
http://mxr.mozilla.org/mozilla-central/source/toolkit/content/widgets/wizard.xml#76
|
|
Assignee | |
Updated•17 years ago
|
Summary: The Update screen does not close on clicking "OK" button → Update wizard back button displayed on Linux when it shouldn't
|
|
Assignee | |
Comment 8•17 years ago
|
||
Turns out that wizard.xml hides / unhides the back button for Linux so it needs to be hidden every time a wizard page is displayed. I also did a little clean up of the more info url code for the updates available page.
Attachment #348070 -
Flags: review?(mconnor)
|
|
||
Updated•17 years ago
|
Attachment #348070 -
Flags: review?(mconnor) → review+
|
|
Assignee | |
Comment 9•17 years ago
|
||
Comment on attachment 348070 [details] [diff] [review]
patch rev 1
I'd like to get this in for B2 if possible.
Attachment #348070 -
Flags: approval1.9.1b2?
|
|
||
Comment 10•17 years ago
|
||
patch is ready. flagging for beta 2
Flags: blocking1.9.1?
Target Milestone: --- → mozilla1.9.1b2
|
|
||
Updated•17 years ago
|
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
|
||
Comment 11•17 years ago
|
||
Blocks, not beta 2, one moment for approval ...
Flags: blocking1.9.1? → blocking1.9.1+
Target Milestone: mozilla1.9.1b2 → mozilla1.9.1
|
|
||
Comment 12•17 years ago
|
||
Comment on attachment 348070 [details] [diff] [review]
patch rev 1
a1.9.1b2=beltzner, but doesn't block
Attachment #348070 -
Flags: approval1.9.1b2? → approval1.9.1b2+
|
||
Comment 13•17 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Target Milestone: mozilla1.9.1 → mozilla1.9.1b2
|
|
||
Updated•17 years ago
|
Keywords: fixed1.9.1
|
|
||
Comment 14•17 years ago
|
||
Verified fix on Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2a1pre) Gecko/20090426 Minefield/3.6a1pre
and Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1b4) Gecko/20090423 Firefox/3.5b4
Status: RESOLVED → VERIFIED
Keywords: fixed1.9.1 → verified1.9.1
You need to log in
before you can comment on or make changes to this bug.
Description
•