464788 - Fix compile warnings in XPConnect

Status: RESOLVED FIXED

(Core :: XPConnect, defect)

Description

[Blake Kaplan (:mrbkap) (inactive)]

Currently, compiling XPConnect gives:

/Users/mrbkap/work/main/mozilla/js/src/xpconnect/src/xpcruntimesvc.cpp:89: warning: unused variable ‘rv’

/Users/mrbkap/work/main/mozilla/js/src/xpconnect/src/xpcwrappednativeinfo.cpp:230: warning: left-hand operand of comma has no effect
/Users/mrbkap/work/main/mozilla/js/src/xpconnect/src/xpcwrappednativeinfo.cpp:231: warning: left-hand operand of comma has no effect

The first warning is trivial. The second warnings are due to the lines:

    STOBJ_SET_PARENT(funobj, nsnull);
    STOBJ_SET_PROTO(funobj, nsnull);

which expand to:

    (void)((!(0) || (((JSObject*)0)->classword |= 1)), (funobj)->fslots[1] = ((j
sval)(0)));
    (void)((!(0) || (((JSObject*)0)->classword |= 1)), (funobj)->fslots[0] = ((j
sval)(0)));

leading to the warning. The fix is to use OBJ_CLEAR_{PARENT,PROTO}.

Comment 1

[Blake Kaplan (:mrbkap) (inactive)]

Attachment: Fix

Comment 2

[Blake Kaplan (:mrbkap) (inactive)]

Comment on attachment 348058 [details] [diff] [review]
Fix

This can wait until after the beta.

Comment 3

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 348058 [details] [diff] [review]
Fix

a191=beltzner

Comment 4

[Peter Van der Beken [:peterv]]

http://hg.mozilla.org/mozilla-central/rev/b258d282bb9b

Next time please follow instructions ("make sure you include a commit message
and an username in the attachment").