464803 - Upgrade to SQLite 3.6.6.2

Status: VERIFIED FIXED

(Core :: SQLite and Embedded Database Bindings, defect, P2)

Description

[Shawn Wilsher :sdwilsh]

Scheduled for release on December 1, 2008.

We cannot take 3.6.5 because our automated test suite caught a bug in it (http://www.sqlite.org/cvstrac/tktview?tn=3497).


Requesting blocking because this blocks bug 462173, and we need a newer SQLite to fix it (anything newer than 3.6.5 will do for that bug).

Comment 1

[Mike Beltzner [:beltzner, not reading bugmail]]

I discussed this with sdwilsh on IRC, and decided that this in itself doesn't block the Firefox 3.1 release since it's hard to block on external dependencies. That said, fixing bug 462173 and allowing async queries will allow for a more responsive UI, and Shawn's obviously been very careful about testing versions of SQLite to ensure they don't break us, so I think that if it comes up for approval, we should seriously consider it.

Comment 2

[Shawn Wilsher :sdwilsh]

Attachment: v1.0

It came out sooner. :)

This also needs the changes to the sqlite files, and that patch can be found here:
http://hg.mozilla.org/users/sdwilsh_shawnwilsher.com/storage-async/file/d0bc383c3001/sqlite.upgrade

Comment 3

[Shawn Wilsher :sdwilsh]

try server shows no regressions

Comment 4

[Andrew Sutherland [:asuth] (he/him)]

Comment on attachment 349089 [details] [diff] [review]
v1.0

I have also verified that the upgrade patch produces results identical to the contents of the sqlite 3.6.6 amalgamation release (though omitting sqlite3ext.h).

Comment 5

[Shawn Wilsher :sdwilsh]

There is a reported corruption issue with 3.6.4 - 3.6.6.  It'll be fixed in 3.6.7, which we should take, and we should block the release of 1.9.1 on.

Comment 6

[Shawn Wilsher :sdwilsh]

3.6.6.1 came out sooner because they didn't like having a release out there with the corruption bug present.

Comment 7

[Shawn Wilsher :sdwilsh]

Attachment: v1.1

Updated our changes for 3.6.6.1.

This also takes http://hg.mozilla.org/users/sdwilsh_shawnwilsher.com/storage-async/file/6554fd2c6e40/sqlite.upgrade

Comment 8

[Mike Beltzner [:beltzner, not reading bugmail]]

Stuart: sdwilsh says you guys want this for mobile, too?

Comment 9

[Stuart Parmenter]

um, yeah, this fixes windows mobile.

Comment 10

[Shawn Wilsher :sdwilsh]

yay...

From sqlite-users mailing list:
SQLite version 3.6.6.2 is now available for download on the SQLite
website

    http://www.sqlite.org/download.html

Version 3.6.6.2 fixes a bug that could potentially lead to database
corruption.  The bug was introduced in SQLite version 3.6.6.  The bug
was discovered by an assert() failure during stress testing and has
not been seen in the wild.

Database corruption resulting from this bug is still only a
theoretical possibility.  Despite focused efforts, we have so far been
unable to generate a test case that actually causes database
corruption.  Nevertheless, the nature of the bug suggests that such a
test should be possible, even if it is difficult to devise.  The fact
we have have been unable in creating a test case suggests the bug is
unlikely to be causing problems in the real world.  Even so, we are
issuing this branch release out of an abundance of caution and
recommending that all users of SQLite version 3.6.6 and 3.6.6.1
upgrade to version 3.6.6.2.


D. Richard Hipp
[e-mail]

Comment 11

[Shawn Wilsher :sdwilsh]

Attachment: v1.3

Same as before, with a version bump

Comment 12

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 350379 [details] [diff] [review]
v1.3

a191=beltzner

Comment 13

[Shawn Wilsher :sdwilsh]

http://hg.mozilla.org/mozilla-central/rev/10099d01717a
http://hg.mozilla.org/mozilla-central/rev/97a05adac5ba

I'll land this on branch later today (once we've had a few runs of perf data)

Comment 14

[Shawn Wilsher :sdwilsh]

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/8de668c33e39
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/5e0ad6a93882

Comment 15

[Tony Chung [:tchung]]

1.9.1 and trunk are up to 3.6.10.  marking bug verified.

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b4pre)
Gecko/20090407 Shiretoko/3.5b4pre

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2a1pre)
Gecko/20090407 Minefield/3.6a1pre