464956 - Don't use REDIRECT_INTERNAL for .url/.desktop files

Status: RESOLVED FIXED

(Core :: Networking: File, defect, P2)

Description

[Boris Zbarsky [:bzbarsky]]

Sicking and I were talking about this, and we're going to special-case REDIRECT_INTERNAL in XHR in ways that make no sense for .url/.desktop.  And in any case, this seems like the wrong redirect type for these files.

Christian, would you prefer that I make all base channel redirects non-internal, or that I push the redirect type determination down into OpenContentStream?  The former is simpler, of course (esp. in terms of the signature of OpenContentStream, though we could let callees not set the redirect type if not redirecting, of course); the latter more flexible.  I would lean towards the latter myself.

We need to fix this for bug 464954 to not get us into trouble, I think.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Like so, perhaps?

Comment 2

[Christian :Biesinger (don't email me, ping me on IRC)]

Comment on attachment 356045 [details] [diff] [review]
Like so, perhaps?

This is fine for now. IMO making this more general can wait until we need it.

Comment 3

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 356045 [details] [diff] [review]
Like so, perhaps?

This blocks some blockers; need it on branch.  Risk is very low: this only changes the behavior of .desktop files in terms of the type of redirect they report.

Comment 4

[Boris Zbarsky [:bzbarsky]]

Pushed http://hg.mozilla.org/mozilla-central/rev/8837f5204f30

Comment 5

[Boris Zbarsky [:bzbarsky]]

Pushed http://hg.mozilla.org/releases/mozilla-1.9.1/rev/e3a2008de3b9

Comment 6

[Daniel Veditz [:dveditz]]

Do you want to land this on 1.9.0 as well? Doesn't sound like we need it necessarily but I don't know if any addon code might make a similar distinction as XS-XHR does in 1.9.1

Comment 7

[Boris Zbarsky [:bzbarsky]]

I suppose we could do that.  I don't feel very strongly either way.