Closed Bug 464956 Opened 11 years ago Closed 11 years ago

Don't use REDIRECT_INTERNAL for .url/.desktop files

Categories

(Core :: Networking: File, defect, P2)

defect

Tracking

()

RESOLVED FIXED
mozilla1.9.2a1

People

(Reporter: bzbarsky, Assigned: bzbarsky)

References

Details

(Keywords: fixed1.9.1)

Attachments

(1 file)

Sicking and I were talking about this, and we're going to special-case REDIRECT_INTERNAL in XHR in ways that make no sense for .url/.desktop.  And in any case, this seems like the wrong redirect type for these files.

Christian, would you prefer that I make all base channel redirects non-internal, or that I push the redirect type determination down into OpenContentStream?  The former is simpler, of course (esp. in terms of the signature of OpenContentStream, though we could let callees not set the redirect type if not redirecting, of course); the latter more flexible.  I would lean towards the latter myself.

We need to fix this for bug 464954 to not get us into trouble, I think.
Flags: blocking1.9.1?
OS: Mac OS X → All
Hardware: x86 → All
Attachment #356045 - Flags: superreview?
Attachment #356045 - Flags: review?
Attachment #356045 - Flags: superreview?(cbiesinger)
Attachment #356045 - Flags: superreview?
Attachment #356045 - Flags: review?(cbiesinger)
Attachment #356045 - Flags: review?
Attachment #356045 - Flags: superreview?(cbiesinger)
Attachment #356045 - Flags: superreview+
Attachment #356045 - Flags: review?(cbiesinger)
Attachment #356045 - Flags: review+
Comment on attachment 356045 [details] [diff] [review]
Like so, perhaps?

This is fine for now. IMO making this more general can wait until we need it.
Comment on attachment 356045 [details] [diff] [review]
Like so, perhaps?

This blocks some blockers; need it on branch.  Risk is very low: this only changes the behavior of .desktop files in terms of the type of redirect they report.
Attachment #356045 - Flags: approval1.9.1?
Pushed http://hg.mozilla.org/mozilla-central/rev/8837f5204f30
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.2a1
Attachment #356045 - Flags: approval1.9.1? → approval1.9.1+
Assignee: nobody → bzbarsky
Flags: blocking1.9.1? → blocking1.9.1+
Priority: -- → P2
Do you want to land this on 1.9.0 as well? Doesn't sound like we need it necessarily but I don't know if any addon code might make a similar distinction as XS-XHR does in 1.9.1
I suppose we could do that.  I don't feel very strongly either way.
You need to log in before you can comment on or make changes to this bug.