Closed Bug 464958 Opened 16 years ago Closed 16 years ago

[FIX]set characterSet of XML DOM document created with createDocument() to UTF-8 and not ISO-8859-1

Categories

(Core :: DOM: Core & HTML, defect)

x86
Windows XP
defect
Not set
normal

Tracking

()

VERIFIED FIXED

People

(Reporter: dveditz, Assigned: bzbarsky)

References

()

Details

(Keywords: regression, verified1.9.0.5)

Attachments

(1 file)

+++ This bug was initially created as a clone of Bug #431701 +++

regression in Firefox 3.0.4 from bug 431701. See bug 431701 comment 36 and following.
Flags: blocking1.9.0.5+
Blocks: 431701
No longer depends on: 431701
Attached patch FixSplinter Review
A little scary, but seems to be ok on trunk, and the only way to get Fx2-compatible behavior without backing out the whole "serialize in document charset" thing...
Attachment #348233 - Flags: superreview?(jonas)
Attachment #348233 - Flags: review?(jonas)
Summary: set characterSet of XML DOM document created with createDocument() to UTF-8 and not ISO-8859-1 → [FIX]set characterSet of XML DOM document created with createDocument() to UTF-8 and not ISO-8859-1
Hey, it is not technical relevant, but THANK YOU (this bug caused most of our applications to fail :)

I am impressed by the speed and I LOVE the transparency of the process.
Attachment #348233 - Flags: superreview?(jonas)
Attachment #348233 - Flags: superreview+
Attachment #348233 - Flags: review?(jonas)
Attachment #348233 - Flags: review+
Attachment #348233 - Flags: approval1.9.0.5?
QA requests a manual testcase or site to cleanly repro this problem. Please make my life easier. :-)
Al, the unit test (with change) will really catch the issue...  I'll see if I can write up an example, I guess, but basically you want to createDocument() a document, put in some non-ASCII text, then use XHR to send it to a server that echoes the input as UTF-8 and see whether the text shows up right.  Not really that simple to set up, sadly.
If it is too complex, don't worry about it since there is a unit test for it. I just like to see these fixes for myself when possible. I can always check the logs like anyone else for the unit tests.
I'm seeing the same problem with our applications and I'm running English(US) Macintosh version.

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.0.4) Gecko/2008102920 Firefox/3.0.4
Comment on attachment 348233 [details] [diff] [review]
Fix

Approved for 1.9.0.5, a=dveditz for release-drivers
Attachment #348233 - Flags: approval1.9.0.5? → approval1.9.0.5+
Fixed on 1.9 branch for 1.9.0.5.
Status: NEW → RESOLVED
Closed: 16 years ago
Flags: in-testsuite+
Keywords: fixed1.9.0.5
Resolution: --- → FIXED
Marking verified for 1.9.0.5 as the unit test has been passing for 1.9.0.
Depends on: 474211
Status: RESOLVED → VERIFIED
Component: DOM: Mozilla Extensions → DOM
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: