464965 - [hi-IN] Remove Bloglines from default RSS readers list

Status: RESOLVED FIXED

(Mozilla Localizations :: hi-IN / hindi, defect)

Description

[Staś Małolepszy :stas]

According to bug 384408 comment 30, we should only have My Yahoo and Google as the default RSS readers for Hindi. This was OK, but this check-in brought Bloglines back:
http://bonsai-l10n.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&root=/l10n&subdir=l10n/hi-IN/browser/chrome/browser-region&command=DIFF_FRAMESET&root=/l10n&file=region.properties&rev1=1.4&rev2=1.5

Please revert this change by submitting to this bug a patch removing Bloglines. The patch can be prepared both in CVS and hg. It will require a review and should land on 1.9.0.x and 1.9.1 trees.

Alternatively, we can replace Bloglines by Netvibes, which is 36% translation complete. What do you think?

Comment 1

[Rajesh Ranjan]

Attachment: patch for cvs

Comment 2

[Rajesh Ranjan]

Attachment: patch for hg

Comment 3

[Staś Małolepszy :stas]

Hi Rajesh. We'll need to change the numbering of the other readers, so that My Yahoo becomes 0 and Google 1. Also, one patch will do, it can be applied to both cvs and hg.

Comment 4

[Axel Hecht [:Pike]]

Comment on attachment 348939 [details] [diff] [review]
patch for cvs

Setting the review and approval flags to denote stas' r-.

Comment 5

[Rajesh Ranjan]

Attachment: patch from hg

as you told I created a patch again by making the required change!

Comment 6

[Axel Hecht [:Pike]]

Comment on attachment 349389 [details] [diff] [review]
patch from hg

r/a=me. Please land this with a check-in comment noting my review, and on cvs with my approval, too. A comment like "bug 464965, remove bloglines from RSS readers, r/a=[e-mail]" would work.

Please use the fixed1.9.0.5 and verified1.9.0.5 keywords to track landing and testing of this patch on cvs for fx 3.0.5.

Comment 7

[Rajesh Ranjan]

I already  submitted it for hg few days back but forgot to put comment!

Comment 8

[Staś Małolepszy :stas]

Great, thanks Rajesh. Can you also commit it to CVS? 'patch -p1' should do the trick. The code freeze for 3.0.5 is this Friday.

Also, please follow the commit comments more closely to what Axel suggests every time he grants a review ("bug 464965, remove bloglines from RSS
readers, r/a=[e-mail]"). The reason for this is to be able for everyone to quickly see in the pushlog who reviewed and approved the patch. Thanks!

Comment 9

[Rajesh Ranjan]

Thanks! I committed that to cvs as well.

Comment 10

[Axel Hecht [:Pike]]

Marking FIXED and fixed1.9.0.5 then.