465113 - Gloda: parentPart is undefined; components/jsmimeemitter.js Line: 279

Status: RESOLVED FIXED

(MailNews Core :: Database, defect, P3)

Description

[Henry N.]

User-Agent:       Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.8.1.6) Gecko/20070730 SUSE/2.0.0.6-25 Firefox/2.0.0.6
Build Identifier: Mozilla/5.0 (X11; U; Linux i686 (x86_64); en-US; rv:1.9.1b2pre) Gecko/20081115 Shredder/3.0b1pre

While Gloda is running in background and is indexing my news this message is shown ones or more for every subscribed news group:

Error: parentPart is undefined
Source File: file:///usr/local/thunderbird-20081115/components/jsmimeemitter.js
Line: 279


Reproducible: Always

Steps to Reproduce:
1.Starting a profile, where Gloda was never enabled
2.Be sure to have some News Groups with lot of header lines (I have 23 on 2 servers)
3.Enable Gloda, restart Thunderbird
4.Wait some minutes, and watch the Error console


Actual Results:  
Error: parentPart is undefined
Source File: file:///usr/local/thunderbird-20081115/components/jsmimeemitter.js
Line: 279

Many often. I feel ones per every news group I have subscribed.

Comment 1

[Wayne Mery (:wsmwk)]

I thought gloda didn't index news?

on XP, I saw probably ~50-100 Error: parentPart is undefined
Source File: file:///C:/Program%20Files/mozilla.org/TB%203.0b%20081116/components/jsmimeemitter.js
Line: 296

Comment 2

[David :Bienvenu]

marking blocking b1 for now - I've seen this myself

Comment 3

[David :Bienvenu]

moving to b2

Comment 4

[Andrew Sutherland [:asuth] (he/him)]

Bug 466438's fix just landed and stops gloda from indexing news messages.  This should stop it from trying to stream them and failing.  Please give tomorrow's nightly a whirl and see if the problem goes away.

I feel like if the problem no longer recurs, we should probably close this as fixed or invalid.  I'm not sure jsmimeemitter needs to be clever enough to deal with an invalid sequence of streaming events due to a broken streaming mechanism.  (The news jsmimeemitter streaming broken-ness will be resolved by beta 2, hopefully mooting the issue moreso.)

Comment 6

[Henry N.]

(In reply to comment #4)
> Bug 466438's fix just landed and stops gloda from indexing news messages.  This
> should stop it from trying to stream them and failing.  Please give tomorrow's
> nightly a whirl and see if the problem goes away.

Am I too early for tomorrow's nightly?
Is not solved at Build Identifier: 20081125030435 (nightly build, US).

Have same same messages, if Gloda is indexing my mail stored mail folders, for example
Profil.Henry/Mail/Local Folders/Project.msf
Profil.Henry/Mail/Local Folders/Project.sbd/lugh.msf
News groups are not touched.

This I have one or two per mail folder
Error: parentPart is undefined
Source File: file:///usr/local/thunderbird-20081125/components/jsmimeemitter.js
Line: 279

This I have one or two per mail folder
Error: partMatch is null
Source File: file:///usr/local/thunderbird-20081125/components/jsmimeemitter.js
Line: 379

This I have more as 200x and scrolled out other messages, created as Bug 466731.
Error: this._log is undefined
Source File: file:///usr/local/thunderbird-20081125/modules/gloda/datastore.js
Line: 1194

Comment 7

[Andrew Sutherland [:asuth] (he/him)]

I agree this still totally happens; looking into it.

Comment 9

[Andrew Sutherland [:asuth] (he/him)]

Attachment: v1 Guard against new unexpected parentPart failures, remove moot _putPart function, update documentation, handle detached/external attachments.

This is primarily the result of bug 478175 and bug 478176, each of which were resulting in incorrect event streams.

Comment 10

[Andrew Sutherland [:asuth] (he/him)]

Comment on attachment 361955 [details] [diff] [review]
v1 Guard against new unexpected parentPart failures, remove moot _putPart function, update documentation, handle detached/external attachments.

('Enter' focus problem).  As noted, other bugs' patches will resolve the fundamental event stream issues that caused us to choke.

The other semantic changes here are to be paranoid and guard against a missing parentPart (which should no longer happen) causing scary error messages.  I would only expect that guard to be used if people plug in new/broken MIME implementations.  The other change is to also handle the case where there is a detached attachment; previously we would explode on that.

Comment 11

[Andrew Sutherland [:asuth] (he/him)]

pushed http://hg.mozilla.org/comm-central/rev/ca4eab958e67