Closed
Bug 465127
Opened 17 years ago
Closed 17 years ago
Disable jemalloc page file support
Categories
(Core :: Memory Allocator, defect)
Core
Memory Allocator
Tracking
()
VERIFIED
FIXED
mozilla1.9.1b3
People
(Reporter: pavlov, Assigned: taras.mozilla)
References
Details
(Keywords: fixed1.9.1, mobile, perf)
Attachments
(1 file, 2 obsolete files)
|
434 bytes,
patch
|
benjamin
:
review+
jasone
:
review+
beltzner
:
approval1.9.1+
|
Details | Diff | Splinter Review |
I don't think the page file support is buying us much, and is causing some performance problems on mobile, so I suggest we disable it until we have time to re-evaluate it.
Flags: blocking1.9.1?
|
||
Comment 1•17 years ago
|
||
I agree.
|
Reporter | |
Comment 2•17 years ago
|
||
taras: can you toss a patch for this together?
Assignee: nobody → tglek
|
Assignee | |
Comment 3•17 years ago
|
||
commented out MALLOC_PAGEFILE
Attachment #350181 -
Flags: review?(benjamin)
|
||
Updated•17 years ago
|
Attachment #350181 -
Flags: review?(benjamin) → review+
|
|
||
Comment 4•17 years ago
|
||
It might be better to instead just change the default for opt_pagefile to false. That leaves the pagefile functionality intact, but disabled unless MALLOC_OPTIONS=o is set.
|
|
Assignee | |
Comment 5•17 years ago
|
||
Attachment #350181 -
Attachment is obsolete: true
Attachment #350848 -
Flags: review?(benjamin)
|
|
Assignee | |
Comment 6•17 years ago
|
||
Sorry, picked the wrong file to upload
Attachment #350848 -
Attachment is obsolete: true
Attachment #350856 -
Flags: review?(benjamin)
Attachment #350848 -
Flags: review?(benjamin)
|
|
||
Updated•17 years ago
|
Attachment #350856 -
Flags: review?(jasone)
Attachment #350856 -
Flags: review?(benjamin)
Attachment #350856 -
Flags: review+
|
|
||
Updated•17 years ago
|
Attachment #350856 -
Flags: review?(jasone) → review+
|
|
Assignee | |
Updated•17 years ago
|
Attachment #350856 -
Flags: approval1.9.1?
|
||
Comment 7•17 years ago
|
||
Can we get this baking on trunk before branch?
|
||
Comment 8•17 years ago
|
||
Taras, go ahead and land this on trunk and report back, showing it doesn't break things. Approval will be easy at that point.
|
|
Assignee | |
Updated•17 years ago
|
Keywords: checkin-needed
|
||
Updated•17 years ago
|
Whiteboard: [c-n: let bug 464995 comment 15+17 bake first]
Version: unspecified → Trunk
|
||
Comment 9•17 years ago
|
||
landed on trunk:
http://hg.mozilla.org/mozilla-central/rev/a178a9b85806
|
|
||
Comment 10•17 years ago
|
||
this worked, the Ts hit on linux went away.
|
|
||
Updated•17 years ago
|
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
|
||
Updated•17 years ago
|
Keywords: checkin-needed
Whiteboard: [c-n: let bug 464995 comment 15+17 bake first]
|
||
Updated•17 years ago
|
Flags: blocking1.9.1? → blocking1.9.1+
|
|
||
Comment 11•17 years ago
|
||
Comment on attachment 350856 [details] [diff] [review]
disable pagefile in a more polite way(for real)
[Checkin: Comment 9 & 14]
a191=beltzner
Attachment #350856 -
Flags: approval1.9.1? → approval1.9.1+
|
|
Assignee | |
Comment 12•17 years ago
|
||
need checkin on 191
|
|
||
Comment 13•17 years ago
|
||
It's still FIXED, it just needs 1.9.1 also
Status: REOPENED → RESOLVED
Closed: 17 years ago → 17 years ago
Resolution: --- → FIXED
|
|
||
Comment 14•17 years ago
|
||
Comment on attachment 350856 [details] [diff] [review]
disable pagefile in a more polite way(for real)
[Checkin: Comment 9 & 14]
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/a241402ddb4b
Attachment #350856 -
Attachment description: disable pagefile in a more polite way(for real) → disable pagefile in a more polite way(for real)
[Checkin: Comment 9 & 14]
|
|
||
Comment 15•17 years ago
|
||
V.Fixed, per comment 10.
Status: RESOLVED → VERIFIED
Keywords: checkin-needed → fixed1.9.1
Target Milestone: --- → mozilla1.9.1b3
You need to log in
before you can comment on or make changes to this bug.
Description
•