Closed Bug 465215 Opened 15 years ago Closed 15 years ago

tab values can get synchronized

Categories

(Firefox :: Session Restore, defect)

Product:
Firefox
Component:
Session Restore
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 3.6a1

People

(Reporter: zeniko, Assigned: zeniko)

References

(
URL
)

Details

(Keywords: fixed1.9.1)

Attachments

(1 file)

fix and tests
5.07 KB, patch
dietrich
: review+
beltzner
: approval1.9.1+
Details | Diff | Splinter Review 
      No description provided.
Attached patch fix and tests — — Splinter Review 
Assignee: nobody → zeniko
Status: NEW → ASSIGNED

        Attachment #348469 -
        Flags: review?(dietrich)

    
    

    
  
Description:

If some custom data is saved for the tab in Session Store and then this tab is duplicated Session Store entries are duplicated so the new tab contains the same data. But when data in the new tab is changed these changes are synchronized with the old tab (values for both tabs are actually the same value).

    
    

    
  
Comment on attachment 348469 [details] [diff] [review]
fix and tests

looks fine, r=me

        Attachment #348469 -
        Flags: review?(dietrich) → review+

    
  
Keywords: checkin-needed
Target Milestone: --- → Firefox 3.1

    
  

        Attachment #348469 -
        Flags: approval1.9.1?
Version: unspecified → Trunk
Keywords: checkin-needed
Whiteboard: [needs approval]

    
    

    
  
Comment on attachment 348469 [details] [diff] [review]
fix and tests

a191=beltzner

        Attachment #348469 -
        Flags: approval1.9.1? → approval1.9.1+

    
  
Keywords: checkin-needed
Whiteboard: [needs approval]

    
    

    
  
http://hg.mozilla.org/mozilla-central/rev/5c0da891a090
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Whiteboard: needs trunk baking
Target Milestone: Firefox 3.1 → Firefox 3.2a1

    
  
Keywords: checkin-needed
Whiteboard: needs trunk baking
Flags: in-testsuite+

    
    

    
  
Please advise on verification steps.

          You need to log in
          before you can comment on or make changes to this bug.