465231 - Toolbar customize doesn't do anything at all, doesn't work

Status: VERIFIED FIXED

(Firefox :: Toolbars and Customization, defect)

Description

[Andrew Websdale]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1b2pre) Gecko/20081116 Minefield/3.1b2pre
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1b2pre) Gecko/20081116 Minefield/3.1b2pre

Customize toolbar, either by right click or from menu. Customize dialog appears, dragging icons or search boxes works but drop does not. No customization is possible, however this was working on 2008-11-14 & maybe the day after(nightly builds)

Reproducible: Always

Steps to Reproduce:
1.select customize toolbar
2.attempt to do so
3.does nothing
Actual Results:  
Nothing

Expected Results:  
Icons should have dropped onto toolbar

Comment 1

[Bill Gianopoulos [:WG9s]]

I am confirming this on all platforms.  Using hg bisect to find the cause.  THe last time this broke weren't some tests checked in to supposedly catch this?

Comment 2

[Bill Gianopoulos [:WG9s]]

hg bisect came up with:

The first bad revision is:
changeset:   21705:6b7faccfd305
user:        Asaf Romano <[e-mail]>
date:        Sat Nov 15 21:47:53 2008 +0200
summary:     Bug 225680 - Ability to detach tabs. r=mconnor, enn. a=beltzner.

Comment 3

[Bill Gianopoulos [:WG9s]]

Reverting the browser.xul portion of the check-in for bug 225680 (which does not seem to relate to the tear-off-tabs feature at all) fixes this issue.

Comment 4

[Asaf Romano (gone)]

Fixed.

Comment 5

[Peter van der Woude [:Peter6]]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b2pre) Gecko/20081118 Minefield/3.1b2pre ID:20081118125341

VERIFIED

Comment 6

[Jim Jeffery not reading bug-mail 1/2/11]

While you can now move an Icon to/from the Customize pallet I see this in Console2 when dragging an Icon from the Pallet to the Toolbar: 

Error: aElt is null
Source file: chrome://global/content/customizeToolbar.js
Line: 682

Comment 7

[Mike Beltzner [:beltzner, not reading bugmail]]

(In reply to comment #6)
> While you can now move an Icon to/from the Customize pallet I see this in
> Console2 when dragging an Icon from the Pallet to the Toolbar: 
> 
> Error: aElt is null
> Source file: chrome://global/content/customizeToolbar.js
> Line: 682

Mano, can you check to see what's causing that? Also, if we could get those tests alluded to in comment 1, that'd be great.

Comment 8

[Jim Jeffery not reading bug-mail 1/2/11]

FWIW, and likely good news, I can no longer repo the error with today's nightly after re-checking the bug.

Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.2a1pre) Gecko/20081202 Minefield/3.2a1pre Firefox/3.0.4 ID:20081202034510

Comment 9

[Tony Chung [:tchung]]

Verified fix on Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US;
rv:1.9.1b3pre) Gecko/20090122 Shiretoko/3.1b3pre 
and Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2a1pre)
Gecko/20090122 Minefield/3.2a1pre