Closed
Bug 465234
Opened 17 years ago
Closed 17 years ago
TM: JIT affects truthiness of ("" <= null)
Categories
(Core :: JavaScript Engine, defect, P1)
Tracking
()
VERIFIED
FIXED
mozilla1.9.1b2
People
(Reporter: jruderman, Assigned: gal)
References
Details
(Keywords: testcase, verified1.9.1)
Attachments
(1 file)
|
1.28 KB,
patch
|
Waldo
:
review+
|
Details | Diff | Splinter Review |
js> for (let j = 0; j < 5; ++j) print("" + ("" <= null));
true
true
false
false
false
|
Assignee | |
Updated•17 years ago
|
Assignee: general → gal
|
|
Assignee | |
Comment 1•17 years ago
|
||
Restrict the shortcut case to == and !=. Its not accurate for relational comparisons.
Attachment #348495 -
Flags: review?
|
|
Assignee | |
Updated•17 years ago
|
Attachment #348495 -
Attachment is patch: true
Attachment #348495 -
Attachment mime type: application/octet-stream → text/plain
|
|
Assignee | |
Updated•17 years ago
|
Attachment #348495 -
Flags: review? → review?(jwalden+bmo)
|
||
Updated•17 years ago
|
Attachment #348495 -
Flags: review?(jwalden+bmo) → review+
|
|
Assignee | |
Comment 2•17 years ago
|
||
http://hg.mozilla.org/tracemonkey/rev/56aa39e5c071
Pushed to TM. No blocker IMO since its a rare odd case, but sayrer's call.
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
|
||
Comment 3•17 years ago
|
||
(In reply to comment #2)
> http://hg.mozilla.org/tracemonkey/rev/56aa39e5c071
>
> Pushed to TM. No blocker IMO since its a rare odd case, but sayrer's call.
I have no idea if this is important for b2 but it could be, and the fix is safe (conservative: abort on string RELOP non-string and vice versa).
/be
|
|
Assignee | |
Updated•17 years ago
|
Severity: normal → critical
Flags: blocking1.9.1?
Priority: -- → P1
Target Milestone: --- → mozilla1.9.1b2
|
||
Comment 4•17 years ago
|
||
reopening, marking blocking beta2, will close once landed on m-c.
Status: RESOLVED → REOPENED
Flags: blocking1.9.1? → blocking1.9.1+
Resolution: FIXED → ---
|
||
Comment 5•17 years ago
|
||
Fixed in the merge pushed by vlad on Nov 18 14:11:14 2008 -0800:
http://hg.mozilla.org/mozilla-central/rev/e8ed5d4bf531
Status: REOPENED → RESOLVED
Closed: 17 years ago → 17 years ago
Resolution: --- → FIXED
|
||
Comment 6•17 years ago
|
||
test landed http://hg.mozilla.org/mozilla-central/rev/9b9749abd247 and cvs
Flags: in-testsuite+
Flags: in-litmus-
|
|
||
Updated•17 years ago
|
Keywords: fixed1.9.1
|
|
||
Comment 7•17 years ago
|
||
v 1.9.1, 1.9.2
Status: RESOLVED → VERIFIED
Keywords: fixed1.9.1 → verified1.9.1
You need to log in
before you can comment on or make changes to this bug.
Description
•