uninitialised value in devutil.c::create_object()

RESOLVED FIXED in 3.12.3

Status

NSS
Libraries
P3
trivial
RESOLVED FIXED
9 years ago
9 years ago

People

(Reporter: Constantine A. Murenin, Assigned: Constantine A. Murenin)

Tracking

Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

9 years ago
Created attachment 348515 [details] [diff] [review]
uninitialised value in arena in devutil.c::create_object()

In nss/lib/dev/devutil.c::create_object(), if the expression inside the first if-statement is true (e.g. the first goto in the function is executed), then we end up referencing a local variable 'arena' that was never initialised. This is a regression from bug #353909 (devutil.c#rev1.27, dated 2006-10-30).  It's also a regression from bug #444974 (devutil.c#rev1.32, dated 2008-09-29), because currently there's one more goto before 'arena' is initialised. :)

Found with LLVM/Clang Static Analyser.
Attachment #348515 - Flags: review?(nelson)
Comment on attachment 348515 [details] [diff] [review]
uninitialised value in arena in devutil.c::create_object()

We'll get this committed after the NSS trunk opens again.
Attachment #348515 - Flags: review?(nelson) → review+
Checking in devutil.c; new revision: 1.33; previous revision: 1.32
Status: ASSIGNED → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
Priority: -- → P3
Target Milestone: --- → 3.12.3
You need to log in before you can comment on or make changes to this bug.