Last Comment Bug 465273 - dead assignment in devutil.c::nssSlotArray_Clone()
: dead assignment in devutil.c::nssSlotArray_Clone()
Status: RESOLVED FIXED
:
Product: NSS
Classification: Components
Component: Libraries (show other bugs)
: trunk
: All All
: P4 trivial (vote)
: 3.12.3
Assigned To: Constantine A. Murenin
:
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-11-16 22:40 PST by Constantine A. Murenin
Modified: 2008-11-19 12:49 PST (History)
0 users
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
dead assignment in devutil.c::nssSlotArray_Clone() (772 bytes, patch)
2008-11-16 22:40 PST, Constantine A. Murenin
nelson: review+
Details | Diff | Splinter Review

Description Constantine A. Murenin 2008-11-16 22:40:36 PST
Created attachment 348516 [details] [diff] [review]
dead assignment in devutil.c::nssSlotArray_Clone()

Dead assignment, it is obviously taken care of by the gcc's optimisation (verifiable by looking at the md5 of devunit.o before and after the patch), but we care about code quality, right? :)

Found with LLVM/Clang Static Analyser.
Comment 1 Nelson Bolyard (seldom reads bugmail) 2008-11-16 22:58:43 PST
Comment on attachment 348516 [details] [diff] [review]
dead assignment in devutil.c::nssSlotArray_Clone()

Yet another patch to wait for the tree to reopen.
Comment 2 Nelson Bolyard (seldom reads bugmail) 2008-11-19 12:49:29 PST
Checking in devutil.c; new revision: 1.33; previous revision: 1.32

Note You need to log in before you can comment on or make changes to this bug.