465329 - sync to breakpad revision 303

Status: RESOLVED FIXED

(Toolkit :: Crash Reporting, defect)

Description

[(not currently active) Ted Mielczarek]

We should sync up to the latest Breakpad code to pick up Mac DWARF support.

Comment 1

[(not currently active) Ted Mielczarek]

I have a patch for just the Breakpad parts, but it's 2.7Mb. I'll have to figure out a decent way of presenting it here. There are some follow-up fixes necessary to Mozilla code to go along with this, but I'll break them out into a separate patch for ease of reviewing.

There are a few weird bits in the patch, notably:
- Lots of file permissions changed (I originally imported files on a Win32 machine, I did this import on a Linux machine, so the permissions are not all goofy)
- Some files have their line endings changed from Windows to Unix. Also a result of the above, should be harmless.

The rest of the patch is all Breakpad changes, including adding a bunch of new files.

Comment 2

[(not currently active) Ted Mielczarek]

Attachment: sync to r299: just the filenames

This is `grep -A2 "^diff"` on my patch. This will at least let you see how many of the file changes are just mode changes, how many are new files, etc.

Comment 3

[(not currently active) Ted Mielczarek]

Attachment: mozilla changes

These are the changes needed on our side to build properly with the updated code. I've built this on all three platforms locally, but not on the exact same code, so I've pushed this to the try server to double check.

Comment 4

[(not currently active) Ted Mielczarek]

Comment on attachment 350008 [details]
sync to r299: just the filenames

Really just looking for an rs here, but if you'd like more details I can post the full patch for you.

Comment 5

[(not currently active) Ted Mielczarek]

Comment on attachment 350033 [details] [diff] [review]
mozilla changes

All green on the try server.

Comment 6

[(not currently active) Ted Mielczarek]

Attachment: mozilla changes

Slight addition, the dwarf library requires -funsigned-char to work correctly.

Comment 7

[(not currently active) Ted Mielczarek]

Bumping up the revision, I checked in a fix (and a fix to my fix). The list of filenames from the diff doesn't change, but the patch contents do slightly.
http://code.google.com/p/google-breakpad/source/detail?r=298
http://code.google.com/p/google-breakpad/source/detail?r=299

Comment 8

[(not currently active) Ted Mielczarek]

Attachment: sync to breakpad revision 303

This is just a diff from r299 - r303. These changes have all been reviewed upstream. This finishes the changes I need to make DWARF support work for us on Mac.

Comment 9

[(not currently active) Ted Mielczarek]

Pushed:
http://hg.mozilla.org/mozilla-central/rev/7aa964f60934
http://hg.mozilla.org/mozilla-central/rev/681b46e69db2
http://hg.mozilla.org/mozilla-central/rev/31281697c166

Comment 10

[(not currently active) Ted Mielczarek]

We should land this and bug 421534 on 1.9.1 after it bakes on trunk for a while.

Comment 11

[(not currently active) Ted Mielczarek]

Comment on attachment 350008 [details]
sync to r299: just the filenames

I'd like to land all three of these patches on the 1.9.1 branch, along with the changes in bug 421534. (And two tiny followup fixes.)

I know this looks like a big scary set of patches, but the net effect is really very tiny, localized mostly to the production of debug symbols on Mac. However, the benefit is pretty big, since this will let us get rid of -save-temps from the CFLAGS of our Mac build machines, which will save us several gigs per build tree in space. (and make RelEng quite happy). In addition, since Thunderbird is now building off of 1.9.1, this should fix a few bad bugs that Thunderbird hits with symbol dumping (since they build static).

Comment 12

[(not currently active) Ted Mielczarek]

Pushed to 1.9.1:
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/90de655f5002
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/55a4f47fcb1e
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/653f284051f6