465348 - GrayText color is too dark on 10.5

Status: VERIFIED FIXED

(Core :: Widget: Cocoa, defect)

Description

[Markus Stange [:mstange]]

Attachment: fix v1

GrayText is used as a text color for disabled labels / buttons and search field placeholders.
In nsLookAndFeel.mm it's currently implemented using kThemeTextColorDialogInactive, which returns #7f7f7f on 10.4 (right) but #454545 on 10.5 (wrong).

I'm attaching a patch that uses [NSColor disabledControlTextColor] instead, which seems to work.

Comment 1

[Josh Aas]

Comment on attachment 348562 [details] [diff] [review]
fix v1

+  return NS_RGB((int)([deviceColor redComponent] * 255),

Don't you want to cast that to an unsigned int instead of a signed int, and the same for the other two components? Also, please write "255.0" instead of "255" so it is more clear that you are doing floating point multiplication there.

Comment 2

[Markus Stange [:mstange]]

Attachment: v2

Comment 3

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 348657 [details] [diff] [review]
v2

a191=beltzner

Comment 4

[Shawn Wilsher :sdwilsh]

http://hg.mozilla.org/mozilla-central/rev/371fbf5d45e0

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Verified with Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b3pre) Gecko/20090202 Shiretoko/3.1b3pre Ubiquity/0.1.5 ID:20090202020439