465463 - [@font-face] style matching with local font should always use @font-face rule style

Status: RESOLVED FIXED

(Core :: Graphics, defect, P4)

Description

[John Daggett (:jtd)]

Fonts defined with @font-face rules should always use the style settings defined by the @font-face rule, not the style implied by information in the font.

Example:

@font-face {
  font-family: test;
  src: local(HelveticaNeue-Light);
  font-weight: bold;
}

In this case, this font should be used as a weight 700 font, not as a weight 200 font.

Comment 1

[John Daggett (:jtd)]

Attachment: testcase, define Helvetica Neue Light as a bold font

Should see Helvetica Neue used when bold is selected.  Comic Sans shows instead because the underlying weights are being used instead of the @font-face defined weights.

Comment 2

[John Daggett (:jtd)]

Attachment: patch, v.0.2, create new font entry for local faces

Rather than use existing font entries, create a new one when src local() is used in @font-face rules.  The new font entry uses the style attributes defined by the @font-face rule rather than the underlying font data.  Also, support both Postscript and full font names.  Full font names will work across platforms but Postscript font names are supported by WebKit, need both to match Safari.  New reftests included, assumes tinderbox machines have Bitstream Vera Sans but won't fail if they don't.

Comment 3

[John Daggett (:jtd)]

Pushed, yay!
http://hg.mozilla.org/mozilla-central/rev/d04183311a19

Comment 4

[John Daggett (:jtd)]

Argh, remember to add reftests...
http://hg.mozilla.org/mozilla-central/rev/f050934dd42e

Comment 5

[John Daggett (:jtd)]

pushed to 1.9.1
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/71c7facd1403