465475 - "timed out waiting for reftest-wait to be removed" in /layout/reftests/bugs/413292-1.html

Status: RESOLVED FIXED

(Core :: General, defect)

Description

[Daniel Holbert [:dholbert]]

According to https://wiki.mozilla.org/Tinderbox/Nov-2008-Orange-Compendium, the test "413292-1.html" has sporadically timed out twice today (11/17) and also twice last Tuesday (11/11). I'm guessing that it's also timed out without being noted on the Compendium on other days, too.

The failure is:
REFTEST TEST-UNEXPECTED-FAIL | file:///builds/slave/trunk_linux-8/build/layout/reftests/bugs/413292-1.html | timed out waiting for reftest-wait to be removed (after onload fired)

So far, this has happened twice on moz2-linux-slave07, once on moz2-linux-slave08, and once on moz2-win32-slave07.

Here are the relevant logs:
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1226983046.1226986577.10789.gz&fulltext=1
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1226940673.1226945806.11914.gz&fulltext=1
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1226437998.1226441805.10673.gz&fulltext=1
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1226389049.1226394771.6229.gz&fulltext=1

The test itself is here:
http://mxr.mozilla.org/mozilla-central/source/layout/reftests/bugs/413292-1.html

Comment 1

[Daniel Holbert [:dholbert]]

Note that this reftest takes 3-4 seconds to complete on my (fast) machine. My guess is that on a slow & loaded-down tinderbox, this test may occasionally not quite finish during the 10-second reftest time limit -- i.e. it's timing out because it's just a really long test.

CC'ing roc, who added the test -- roc, do you agree with this diagnosis?   And if so, would it be possible to shorten the reftest a bit so that it's less likely to sporadically fail?

Comment 2

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Sure, just decrease the iteration count from 20 to 10 or whatever.

Comment 3

[Daniel Holbert [:dholbert]]

Attachment: patch for test: reduce iteration count from 20 to 10

Comment 4

[Daniel Holbert [:dholbert]]

Pushed patch (attachment 348721 [details] [diff] [review]) as http://hg.mozilla.org/mozilla-central/rev/c8fb5d5f16e4

Comment 5

[Johnathan Nightingale [:johnath]]

Still failing on Nov 19:

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1227091046.1227096921.6997.gz

Comment 6

[Robert O'Callahan (:roc) (email my personal email if necessary)]

I've got an idea. How about we rewrite looop so instead of stopping after a fixed number of iterations, it keeps going for 3 seconds and then stops?

Comment 7

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Yeah, just failed again.

Comment 8

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: fix

This restores the loopcount to 20 but adds an additional check to stop (and succeed) if we've taken more than 5 seconds. That gives us five seconds to complete the last iteration before hitting the reftest timeout --- I hope that's enough!

Comment 9

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Pushed to trunk as 1a51935c654b

Comment 10

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/43afeae6673a