465512 - New navigation bar contains some flaws under MacOS

Status: RESOLVED FIXED

(Calendar :: Calendar Frontend, defect)

Description

[Berend Cornelius]

The navigation bar contains the following flaws:
- It is too high
- The font-sizes are not unique over the panel
- the bottom panel is interrupted at the tabs control.
- the labels are not on the same level

Comment 1

[Berend Cornelius]

Attachment: [checked in] patch v. #1

This patch should take care of it. The today button is still the problem child of the pane which is already covered by another bug

Comment 2

[Daniel Boelzle [:dbo]]

Comment on attachment 348756 [details] [diff] [review]
[checked in] patch v. #1

>--- a/calendar/base/themes/pinstripe/calendar-views.css
> .today-navigation-button {
>@@ -712,7 +716,9 @@ tab[calview]:hover {
>     -moz-margin-end: 2px;
>     margin-bottom: 0px;
>     color: #2E4E73;
>+    font-size: 14px;s
                      ^
There's a typo 's' in the patch, thus the rule gets dropped. Removing it the views look good on Mac; r=dbo.

Comment 3

[Berend Cornelius]

patch pushed to commm-central:
http://hg.mozilla.org/comm-central/rev/2bb74cea362b

->fixed

Comment 4

[Andreas Treumann]

Attachment: missing borders

Comment 5

[Andreas Treumann]

Some flaws still exists (vertical alignment and missing borders), see screenshoot.

Comment 6

[Elliot Anders]

Attachment: Patch for baseline adjustments of the navigation bar

I've just spent some time trying to straighten out the vertical alignment of the navigation area.  It seems impossible to move the word Today down, so I've moved the other words on the background up.  The I've left the tabs where they were, so there re still 3 different baselines, but I think it looks pretty good.  Could someone take a look?

Screenshot to follow.

Comment 7

[Elliot Anders]

Attachment: Screen shot of navigation

Comment 8

[Philipp Preißer-Kewisch [:Fallen][☁️📆]]

Comment on attachment 371179 [details] [diff] [review]
Patch for baseline adjustments of the navigation bar

Daniel, could you look into this since you have the mac?

Comment 9

[Daniel Boelzle [:dbo]]

Comment on attachment 371179 [details] [diff] [review]
Patch for baseline adjustments of the navigation bar

calendar week and navgigation now look in sync, but the tabs don't, which looks quite odd sinc they are located nearby.

Comment 10

[Martin Schröder [:mschroeder]]

Comment on attachment 371179 [details] [diff] [review]
Patch for baseline adjustments of the navigation bar

This patch may also need ui-review!

Comment 11

[Martin Schröder [:mschroeder]]

(In reply to comment #10)
> (From update of attachment 371179 [details] [diff] [review])
> This patch may also need ui-review!

After talking to Philipp, this patch does not need ui-review.

Elliot, can you please try to fix the issue Daniel mentioned in comment#9?

Comment 12

[Elliot Anders]

I'll give it a try.  Just to be clear before I start, the text of the tabs should be higher or everything else should be lower right?

-Elliot

Comment 13

[Elliot Anders]

Attachment: Patch for better navigation text display

Here's a better patch for the navigation line spacing issue.  Let me know if it doesn't solve the issue for anyone.

Comment 14

[Elliot Anders]

Attachment: Additional fix for the navigation section

If the previous patch I submitted gets accepted this would help improve the navigation area as well.  I'm submitting it separately as it touches calendar-views.xul as well as the css file so I'm guessing it will need additional review, and it shouldn't hold up the other patch.

Comment 15

[Stefan Sitter [:ssitter]]

Did you changed
    /calendar/base/themes/winstripe/calendar-views.css
or
    /calendar/base/themes/pinstripe/calendar-views.css
or both? This is not clear from your patches.

Comment 16

[Elliot Anders]

this is calendar.jar/skin/calendar/calendar-views.css

Comment 17

[Philipp Preißer-Kewisch [:Fallen][☁️📆]]

(In reply to comment #15)
> Did you changed
>     /calendar/base/themes/winstripe/calendar-views.css
> or
>     /calendar/base/themes/pinstripe/calendar-views.css
> or both? This is not clear from your patches.

(In reply to comment #16)
> this is calendar.jar/skin/calendar/calendar-views.css

Since Elliot uses a Mac I'm guessing its the pinstripe file. For clarification, pinstripe is our mac theme and winstripe is the windows/linux theme. When building, only the theme for the current os is packaged, therefore you have only one.

Comment 18

[Elliot Anders]

it would be pinstripe then.  I was working off the latest nightly build on Leopard.

Comment 19

[Daniel Boelzle [:dbo]]

Elliot, could you please attach a clean patch? Would make it easier to test the changes. Thanks!

Comment 20

[Elliot Anders]

Daniel,
sorry for being uninformed, but what do you mean by a clean patch?  
Did you want both patches rolled into one, or something else?

Comment 21

[Daniel Boelzle [:dbo]]

A clean git patch, e.g. thru |hg diff|. Yes, put both changes into one.

Comment 22

[Elliot Anders]

Attachment: fixes the baseline and tab design on mac os x

Sorry for the delay, my wife just had our first kid.  It's kind of distracting.
Here's the pinstripe patch.  I'm pretty sure we'll need a winstripe patch as well with the changes to the xul file.  Any chance someone else could look at that?  
-Elliot

Comment 23

[Daniel Boelzle [:dbo]]

Comment on attachment 379891 [details] [diff] [review]
fixes the baseline and tab design on mac os x

Looks good on Mac; r=dbo

I am moving review to Fallen, maybe he could add the winstripe part... ;-)

Comment 24

[Elliot Anders]

Attachment: Pinstripe and Winstripe changes

Here's a patch for both winstripe and pinstripe to keep the two views in sync.
Could someone please review?

Comment 25

[Martin Schröder [:mschroeder]]

Comment on attachment 385520 [details] [diff] [review]
Pinstripe and Winstripe changes

I'll have a look at the patch.

Comment 26

[Martin Schröder [:mschroeder]]

Comment on attachment 385520 [details] [diff] [review]
Pinstripe and Winstripe changes

Elliot, can you provide screenshots for Mac and Windows/Linux to show what your latest patch looks like?

Bryan, can you have a look at those changes to the calendar view, please? I would feel better if we get an ui-review, although Philipp decided earlier it wouldn't be necessary.

Comment 27

[Elliot Anders]

Attachment: Pinstripe Screenshot

Comment 28

[Elliot Anders]

Attachment: Winstripe Screenshot

Comment 29

[Bryan Clark (DevTools PM) [:clarkbw]]

Comment on attachment 385520 [details] [diff] [review]
Pinstripe and Winstripe changes

The pinstripe looks good with the tightened spacing.  The winstripe theme looks like it could use similar tightening up.  Is this patch affecting that?

plus for now since this is an improvement to the pinstripe.

Comment 30

[Decathlon]

What about move all tabs to the extreme right with a few pixels (or no pixel) margin? This would help to gain a little space for date description in particular for multiweek view.

Comment 31

[Elliot Anders]

It would be quite easy to move the tabs further to the right, and as long as they weren't completely squished I think it would look good.  
I noticed the font size for "Today" on the winstripe version is smaller than the pinstripe version.
The tabs on winstripe seem to have some more depth, which I'm not sure is needed.
Would people like me to modify this so the two look essentially the same (more like the pinstripe version) and the tabs are further to the right?

Comment 32

[Martin Schröder [:mschroeder]]

Comment on attachment 385520 [details] [diff] [review]
Pinstripe and Winstripe changes

Elliot, sorry for taking so long to give your patch a first review. As you suggested in comment#31, a modification of the winstripe theme to look more like the pinstripe one would be appreciated. Also moving the tabs further to the right is a good thing.

>diff --git a/calendar/base/themes/pinstripe/calendar-views.css b/calendar/base/themes/pinstripe/calendar-views.css
>--- a/calendar/base/themes/pinstripe/calendar-views.css
>+++ b/calendar/base/themes/pinstripe/calendar-views.css
>@@ -611,51 +611,54 @@ calendar-month-day-box-item[status="CANC
[...]
>+#today-view-button {
>+    padding-bottom: 0;
>+    margin-bottom: 0;
> }

We already have a rule for .today-navigation-button (class), so an additional rule for the element id shouldn't be necessary. Please, try to merge them. :)


>+
>+#view-tabs {
>+    padding-right: 20px;
> }

The same applies here. You don't need a new #view-tabs rule but can use the existing .calview-tabs one below.

> .calview-tabs {
>     margin-bottom: 0;
> }

Comment 33

[Elliot Anders]

Martin,
thanks for the feedback, I'll submit a patch shortly to bring winstripe and pinstripe closer together and to move the tabs further right.  I can't however seem to find any definition of view-tabs or calview-tabs, can you tell me which file those are in?

Comment 34

[Elliot Anders]

Attachment: [checked in] Updated patch for winstripe and pinstripe

Things seem to be changing very quickly on the winstripe side, so I'm not sure this will make the two look identical, but it tightens things up a bit and once accepted I'll take another crack at cleaning things up.

Comment 35

[Philipp Preißer-Kewisch [:Fallen][☁️📆]]

Comment on attachment 389135 [details] [diff] [review]
[checked in] Updated patch for winstripe and pinstripe

After de-bitrot, the patch looks fine on mac. Just one small issue, font-size should be using a relative unit like em's.

r=philipp

Elliot, as a bonus since the review took so long I can take care of the changes. I would still appreciate if you could help out if the mac theme needs tweaking in the future. Review should be quicker now that I have a mac.

Comment 36

[Philipp Preißer-Kewisch [:Fallen][☁️📆]]

Pushed to comm-central <http://hg.mozilla.org/comm-central/rev/799b59500550>
-> FIXED

Comment 37

[Philipp Preißer-Kewisch [:Fallen][☁️📆]]

Backported to comm-1.9.2 <http://hg.mozilla.org/releases/comm-1.9.2/rev/87a75ae7f519>
a=philipp

Comment 38

[Decathlon]

Attachment: Comparison "after-before" the patch on Win XP

I think something needs to change, at least on Win XP.
IMHO the "Today" text in the button is too big in particular compared with the text for the month name. Moreover the global header seems a bit low.

Comment 39

[Philipp Preißer-Kewisch [:Fallen][☁️📆]]

Yep, looks like a bug. Reopening, I can take a look in the next few days (I wouldn't be sad if someone else does though ;-)

Comment 40

[Ilja Sekler]

On Linux (comm-1.9.2), font size of "Today" label is not too big and exactly matches 14px for the month name as specified for .view-header, but it is vertically not aligned with navigation buttons. Overriding these rules with

#today-view-button {
  padding-bottom: 0px !important;
}

.today-navigation-button {
  margin-top: 3px !important;
}

looks IMVHO quite right.

BTW, there is a typo in calendar/base/themes/winstripe/calendar-views.css at line 689 for #today-view-button ("margin-botom").

Comment 41

[Philipp Preißer-Kewisch [:Fallen][☁️📆]]

Attachment: Fix winstripe Regression - v1

Decathlon, does this also fix the regression for you on winxp? It works for me on linux.

Comment 42

[Decathlon]

Attachment: Fix winstripe Regression patch: screenshot WinXp Luna theme

I can't test on Shredder because I get a lot of errors when creating a profile with Lightning and it doesn't work completely.
I've adapted the patch for Lanikai and tested with the XP Luna theme and the tabs look better. Maybe they should be more similar to the Thunderbird's tab  in particular for the shadow effect between adjacent tabs, anyway I see it's not easy to get the same look also because Thunderbid's tab have gradient images.

The problem is also the "Today" button. As Ilja Sekler pointed out, there is a vertical misalignment of the text and with the next/previous buttons. Moreover, IMHO, the month (weeks) name should be prominent compared with the text in the button. A button with a fixed 14px font size is totally different from every other buttons in Lightning and in Thunderbird too. See also other applications (Outlook, Google calendar, etc.): the month name in the views header is prominent compared with a normal button, and where the size is the same, bold style is used for the month name.

I've just read comment 31 and comment 32 and I've realized that the bigger button has been done on purpose because "it is smaller than the button in the pinstripe theme" but actually that text depends on system font size, I know that because, when I fixed bug 465317, I had to try a lot of combinations of font sizes and themes to adapt alignment of the navigation buttons (today and arrow buttons) with the text in the header views as you can see from the several screenshots I attached there.
If we want to make the button with a fixed size, well, I agree, it makes by far simpler the alignment (that however it needs to be done), but please, make somehow the month name prominent compared with the text in the button.

Comment 43

[Philipp Preißer-Kewisch [:Fallen][☁️📆]]

Hrmpf, it looks much different than on linux. I'll see what I can do! Sorry Ilja, I missed your comment and will adapt in the next patch.

Comment 44

[Decathlon]

Attachment: Proposal: font size and tabs

What about something similar to this proposal?
The tabs' look isn't too different from Thunderbird's tabs and the font size 12px is the same (at least on Windows).

Comment 45

[Ilja Sekler]

Attachment: Navigation bar in Calendar tab on Linux

This includes "Fix winstripe Regression - v1" patch && typo correction && 

#today-view-button {
  padding-bottom: 0px !important;
  margin-top: 1px !important;
}

#previous-view-button, #next-view-button {
  margin-top: 1px !important;
  padding-top: 1px !important;
}

in userChrome.css. Though "Today" is one pixel higher than the month name, but IMHO it still looks OK and saves one pixel of vertical space in #calendar-nav-control (computed height: 36px).

I wonder if the real issue is that there is no Gnomestripe theme for Lightning to match the rest of Thunderbird on Linux and to allow isolated fixes for Windows which doesn't affect Linux.

Comment 46

[Philipp Preißer-Kewisch [:Fallen][☁️📆]]

It seems the two of you have a good grip on this issue, I think it would be best if you could decide on a combined patch that looks good on linux+windows. 
Visually, I'm fine with any proposal.

Unfortunately we don't have gnomestripe yet, due to bug 533096 not being fixed yet (it will need a new patch anyway, bummer). I also don't think we should take gnomestripe for the upcoming release.

Comment 47

[Ilja Sekler]

Attachment: Winstripe polish and typo fix

This is just Philipp's "Fix winstripe Regression - v1" patch with small adjustments and with a typo fix for <http://hg.mozilla.org/comm-central/rev/799b59500550#l3.20> to match the appearance <https://bugzilla.mozilla.org/attachment.cgi?id=515023> on Linux. It has been tested on Linux trunk only. A test on Windows would be highly appreciated.

I'll test on comm-1.9.2 later.

Comment 48

[Decathlon]

Attachment: Winstripe polish and typo fix: screenshot on Win7

(In reply to comment #47)
> A test on Windows would be highly appreciated.

Comment 49

[Decathlon]

Forgot to say that in the little space on the extreme right, beside the "month" tab, a bottom border is missing.

Comment 50

[Ilja Sekler]

(In reply to comment #48)
> Created attachment 516027 [details]
> Winstripe polish and typo fix: screenshot on Win7

Thanks a lot, I wonder why .view-header ("February 27 - Mach 26, 2011" and "CWs: 9-12") is displayed 1px lower and the height of .view-tabs is 2px less than on Linux (26px vs. 28px). This causes the "Today" label to be 2px higher than the text on the right, which breaks the visual harmony.

> Forgot to say that in the little space on the extreme right,
> beside the "month" tab, a bottom border is missing.

What are the spacers .tabs-left and .tabs-right for?

.tabs-right {
    width: 4px;
    border-bottom: 1px solid #D2D2D2;
}

instead of

#view-tabs {
    padding-right: 4px;
}

would fix this, but I don't know whether this were a misuse of the spacer and where the tabs are supposed to be in rtl locales.

Comment 51

[Decathlon]

(In reply to comment #50)
> (In reply to comment #48)
> > Created attachment 516027 [details]
> > Winstripe polish and typo fix: screenshot on Win7
> 
> Thanks a lot, I wonder why .view-header ("February 27 - Mach 26, 2011" and
> "CWs: 9-12") is displayed 1px lower and the height of .view-tabs is 2px less
> than on Linux (26px vs. 28px). This causes the "Today" label to be 2px higher
> than the text on the right, which breaks the visual harmony.
> 

With the fix for bug 465317 some elements were introduced to adapt the alignment with different font size for the "today" text inside the button. Now, with a fixed text size something could be changed.
By chance, does changing the margin-bottom attribute in the view-header class from -1px to 0px affect the position on Linux? (on Win it does)

 .view-header {
     font-weight: normal;
     font-size: 14px;
     color: #2E4E73;
-    margin-bottom: -1px;
+    margin-bottom: 0px;
 }

> What are the spacers .tabs-left and .tabs-right for?

As far as I can see those classes don't have a related element in any xul file:

http://mxr.mozilla.org/comm-central/search?string=tabs-right&find=%2Fcalendar%2F&findi=&filter=^[^\0]*%24&hitlimit=&tree=comm-central

if they aren't dynamically applied somewhere to some XUL element by js code, I think they could be deleted (Philipp's opinion needed here).

> .tabs-right {
>     width: 4px;
>     border-bottom: 1px solid #D2D2D2;
> }
> 
> instead of
> 
> #view-tabs {
>     padding-right: 4px;
> }
> 
> would fix this, but I don't know whether this were a misuse of the spacer and
> where the tabs are supposed to be in rtl locales.

To get that border in the screenshot proposal (https://bugzilla.mozilla.org/attachment.cgi?id=514939) I added a simple box in the place of the original scroolbar spacer (that has been deleted with the last checked-in patch) with own class (with bottom border and 4 pixels width) but maybe it's possible in some other way.

Comment 52

[Ilja Sekler]

(In reply to comment #51)

> By chance, does changing the margin-bottom attribute in the view-header
> class from -1px to 0px affect the position on Linux? (on Win it does)

It works on Linux too, but does not look right. The arrow image on the #next-view-button produces an illusion of the text in .view-header being higher than the "Today" label. The text seems to be pushed too far to the top of the available vertical space.

>> What are the spacers .tabs-left and .tabs-right for?
> 
> As far as I can see those classes don't have a related element in any
> xul file:
> 
> http://mxr.mozilla.org/comm-central/search?string=tabs-right&find=%2Fcalendar%2F&findi=&filter=^[^\0]*%24&hitlimit=&tree=comm-central
> 
> if they aren't dynamically applied somewhere to some XUL element by
> js code, I think they could be deleted (Philipp's opinion needed here).

At a closer look they stem from <http://mxr.mozilla.org/mozilla-central/source/toolkit/content/widgets/tabbox.xml#233>. CSS rules applied to them in <http://mxr.mozilla.org/comm-central/source/calendar/base/themes/winstripe/calendar-views.css#717> don't match the border style in .navigation-inner-box anyway, so something should be done here.

Comment 53

[Ilja Sekler]

Attachment: Winstripe polish v3

This is merely an attempt to streamline CSS rules and to remove redundant or ineffective parts. The patch doesn't change anything in the appearance of the calendar navigation bar on Linux and touches only calendar-views.css.

Decathlon, could you please test this patch on Windows? If .view-header still gets placed two pixel lower than "Today" label, please check whether deleting margin-top property for .view-header fixes this on Windows.

On comm-1.9.2, there are issues with tab[calview] borders introduced by removal of "-moz-border-*-colors: #D2D2D2 transparent;" rules in <http://hg.mozilla.org/releases/comm-1.9.2/rev/87a75ae7f519>, this part of the checkin should be IMVHO reverted.

Comment 54

[Ilja Sekler]

Attachment: Winstripe polish v3 (typo fixed)

The correct patch without a typo. Sorry!

Comment 55

[Decathlon]

Attachment: Winstripe polish v3 (typo fixed): screensht on Win7

(In reply to comment #52)
> >> What are the spacers .tabs-left and .tabs-right for?
> > 
> > As far as I can see those classes don't have a related element in any
> > xul file:
> At a closer look they stem from
> <http://mxr.mozilla.org/mozilla-central/source/toolkit/content/widgets/tabbox.xml#233>.

Oopss..., I searched only inside the calendar directory, sorry.
So they are classes related to spacers, hence they can't have any visible border, is it right? In this case the border

 .tabs-left,
 .tabs-right {
-    border-bottom: 2px solid #D2D2D2;
+    border-bottom: 1px solid #D2D2D2;
 }

seems useless, I can't view it neither as written above nor in any other way (different thickness or color).
In order to make that border visible, in the attachment 514939 [details] I used a box with own class, like the original deleted with the previous checked-in patch http://hg.mozilla.org/comm-central/rev/799b59500550#l1.12 but without the scrollbar element inside.
I will send you an email with another attempt of patch.


(In reply to comment #53)
> This is merely an attempt to streamline CSS rules and to remove redundant or
> ineffective parts. The patch doesn't change anything in the appearance of the
> calendar navigation bar on Linux and touches only calendar-views.css.
> 
> Decathlon, could you please test this patch on Windows? If .view-header still
> gets placed two pixel lower than "Today" label, please check whether deleting
> margin-top property for .view-header fixes this on Windows.

Deleting the margin-top property, "Today" button and the label look aligned but they are both 2 pixels too low, you can see better with the "Today" button in hover status (see screenshot): the text is not centered in the button.


> On comm-1.9.2, there are issues with tab[calview] borders introduced by removal
> of "-moz-border-*-colors: #D2D2D2 transparent;" rules in
> <http://hg.mozilla.org/releases/comm-1.9.2/rev/87a75ae7f519>, this part of the
> checkin should be IMVHO reverted.

I agree, but they need to be adapted to the new look that is quite different.

Comment 56

[Ilja Sekler]

Attachment: Winstripe polish v4

> Deleting the margin-top property, "Today" button and the label look
> aligned but they are both 2 pixels too low, you can see better with
> the "Today" button in hover status (see screenshot): the text is not
> centered in the button.

Does it happens also with

.view-navigation-button, .today-navigation-button {
     -moz-appearance: none !important;
}

or with

.view-navigation-button, .today-navigation-button {
     min-height: 29px !important;
}

in userChrome.css?

It looks as if we were fighting a hopeless fight against platform-specific styling, which is really bad on Windows, judging from your screenshots. A small remedy could be a min-height of 29px for .view-navigation-button and .today-navigation-button, which would stretch them up to their vertical dimensions on Linux. If a test with these rules in userChrome.css happens to be positive, please try the new patch. I reduced -moz-margin-(start|end) to 1px following your advice and decided to go without margin-top for .view-header.

> So they are classes related to spacers, hence they can't have any
> visible border, is it right?

Sorry, I can't follow. IMVHO they can be styled in any reasonable way, border property works fine on Linux and is visible if the width of the spacer is non-zero.

>> On comm-1.9.2, there are issues with tab[calview] borders introduced
>> by removal of "-moz-border-*-colors: #D2D2D2 transparent;" rules in
>> <http://hg.mozilla.org/releases/comm-1.9.2/rev/87a75ae7f519>, this part
>> of the checkin should be IMVHO reverted.
> 
> I agree, but they need to be adapted to the new look that is quite
> different.

On Linux, if these rules are reverted, the appearance of calview-tabs on comm-1.9.2 matches the look on trunk. I'll attach a screenshot.

Comment 57

[Ilja Sekler]

Attachment: Screenshot of calendar view tabs on comm-1.9.2

Comment 58

[Philipp Preißer-Kewisch [:Fallen][☁️📆]]

1.9.2 is "not that important". The next release will likely be from comm-central, so as long as it doesn't look broken on 1.9.2 I'm happy. Hope this helps :)

Comment 60

[Philipp Preißer-Kewisch [:Fallen][☁️📆]]

We can also backout the original patch from comm-1.9.2 if it helps. Whats the status on this bug? Are any of the patches ready for review?

Comment 61

[Ilja Sekler]

(In reply to comment #60)

> We can also backout the original patch from comm-1.9.2 if it helps.

I have both an isolated patch for calview-tabs borders and an all-in-one patch ported to comm-1.9.2, which works fine on Linux, so I don't think that a backout is necessary.

> Whats the status on this bug? Are any of the patches ready for review?

We are stuck at different platform-specific styling of -moz-appearance:toolbarbutton on Linux and on Windows. Text within a toolbarbutton on Windows is vertically not in the middle but displaced 2 or 3px to the bottom, which destroys alignment with .view-header. Decathlon suggested

.today-navigation-button {
    padding-top: 0px !important;
}

as a workaround sufficient to correct the issue on Windows. Now awaiting feedback for v6 of the patch.

I'm going to attach the aforementioned patch here as-is, testing on Windows would be highly appreciated.

Comment 62

[Ilja Sekler]

Attachment: Winstripe polish v6 for comm-central

Not requesting formally a review yet, but feedback is highly appreciated.

Are calview-tabs on the right side of the header in rtl locales too?

Comment 63

[Decathlon]

Attachment: Winstripe polish v6 for comm-central: screenshot on Win 7

Details in a mail to your mailbox (written before reading here on Bugzilla) ;-)

Comment 64

[Ilja Sekler]

Comment on attachment 518949 [details] [diff] [review]
Winstripe polish v6 for comm-central

Judging from https://bug465512.bugzilla.mozilla.org/attachment.cgi?id=519006 the results with the patch look satisfactory enough on Windows. Asking for review.

Comment 65

[juergen.edner]

(In reply to comment #40)

> BTW, there is a typo in calendar/base/themes/winstripe/calendar-views.css at
> line 689 for #today-view-button ("margin-botom").

I can confirm that this typo has still not been fixed in the Lightning nightly 20110312034501. The exact error message is

Warning: Unknown property 'margin-botom'. Declaration ignored.
Source file: chrome://calendar/skin/calendar-views.css
Row: 697

Should I open a separate bug report for it?

Comment 66

[Stefan Sitter [:ssitter]]

(In reply to comment #65)
I did with Bug 639981 but it was marked as duplicate of this one (comment 59).

Comment 67

[Philipp Preißer-Kewisch [:Fallen][☁️📆]]

Comment on attachment 518949 [details] [diff] [review]
Winstripe polish v6 for comm-central

r=philipp, looks fine on mac and the screenshots assume the same for windows.

Comment 68

[Philipp Preißer-Kewisch [:Fallen][☁️📆]]

Pushed to comm-central <http://hg.mozilla.org/comm-central/rev/409ba725a3ae>
-> FIXED

Comment 69

[Philipp Preißer-Kewisch [:Fallen][☁️📆]]

Backported to comm-1.9.2 <http://hg.mozilla.org/releases/comm-1.9.2/rev/d7567f1ad68e>
a=philipp

Comment 70

[Ilja Sekler]

Attachment: Make calview tab borders on comm-1.9.2 look like on trunk

This is the small follow-up patch for calview borders on comm-1.9.2 mentioned in comment #61.

Comment 71

[Philipp Preißer-Kewisch [:Fallen][☁️📆]]

Comment on attachment 520754 [details] [diff] [review]
Make calview tab borders on comm-1.9.2 look like on trunk

r=philipp for comm-1.9.2

Comment 72

[Philipp Preißer-Kewisch [:Fallen][☁️📆]]

Comment on attachment 520754 [details] [diff] [review]
Make calview tab borders on comm-1.9.2 look like on trunk

Pushed to comm-1.9.2 rev 2d9cfe35a611