Closed Bug 465551 Opened 12 years ago Closed 12 years ago

Additional localization comments needed in calendar-event-dialog.properties

Categories

(Calendar :: General, defect, minor)

defect
Not set
minor

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: iacchi, Assigned: bv1578)

References

()

Details

Attachments

(1 file, 2 obsolete files)

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; it; rv:1.9.0.3) Gecko/2008092416 Firefox/3.0.3
Build Identifier: 

If you open calendar-event-dialog.properties you'll notice that some strings have up to 5 vars inside, but they have no comment which explains which text will replate a variable.
To make a good translation of these strings, we should know the meaning of the variables.

Reproducible: Always
Component: Other → General
Product: Mozilla Localizations → Calendar
QA Contact: general
Status: UNCONFIRMED → NEW
Ever confirmed: true
Flags: wanted-calendar1.0?
Summary: Comments needed to localize calendar-event-dialog.properties the right way → Additional localization comments needed in calendar-event-dialog.properties
Assignee: nobody → bugzilla
Severity: major → normal
Flags: wanted-calendar1.0? → wanted-calendar1.0+
Status: NEW → ASSIGNED
I've attached a calendar-event-dialog.properties which contains comments to explain the var usage; check it for mispelling.

I don't know how the "switch" works on Mozilla Translator (from 5.24), but the comments should be readeable in any string: it would simplify the translation process.
Attached file File replacement with comments (obsolete) —
Attached patch proposal with comments (obsolete) — Splinter Review
This is the same file attached by Iacopo with more comments (a comment for every string).
Same request for check as in comment #1.
Thanks in advance.
Attachment #352947 - Flags: review?(Berend.Cornelius)
Attachment #352909 - Attachment is obsolete: true
Comment on attachment 352947 [details] [diff] [review]
proposal with comments

>+# Edit recurrence window -> Recurrence pattern -> Daily repeat rules
> repeatDetailsRuleDaily1=every day

I suggest to use the recommended format for the localization notes <https://developer.mozilla.org/En/Localization_notes>, e.g.

# LOCALIZATION NOTE (repeatDetailsRuleDaily1): comment
Attachment #352947 - Attachment is obsolete: true
Attachment #352947 - Flags: review?(Berend.Cornelius)
Thanks Stefan for your suggestion.
Made required changes.
I don't know if a request for approval1.9.1 must be set. Could you please set the flag if the patch needs it?
Attachment #353017 - Flags: review?(Berend.Cornelius)
Comment on attachment 353017 [details] [diff] [review]
patch v1 with established format for localization notes

I find the comments short but also concise so altogether very good. r=berend.
Attachment #353017 - Flags: review?(Berend.Cornelius) → review+
patch pushed to comm-central:

http://hg.mozilla.org/comm-central/rev/da54c7e0fb5b

issue is fixed.
I hope I spelled the name of Bas correctly
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Assignee: bugzilla → bv1578
Severity: normal → minor
Target Milestone: --- → 1.0
Checked and verified.
Status: RESOLVED → VERIFIED
Decathlon pointed out a mistake that I made when pushing the patch to comm-central: Bas was was not the patch distributor as I wrote in my comment. I am sorry about that.
Target Milestone: 1.0 → 1.0b1
You need to log in before you can comment on or make changes to this bug.