465551 - Additional localization comments needed in calendar-event-dialog.properties

Status: VERIFIED FIXED

(Calendar :: General, defect)

Description

[Iacopo Benesperi [:iacchi]]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; it; rv:1.9.0.3) Gecko/2008092416 Firefox/3.0.3
Build Identifier: 

If you open calendar-event-dialog.properties you'll notice that some strings have up to 5 vars inside, but they have no comment which explains which text will replate a variable.
To make a good translation of these strings, we should know the meaning of the variables.

Reproducible: Always

Comment 1

[Iacopo Benesperi [:iacchi]]

I've attached a calendar-event-dialog.properties which contains comments to explain the var usage; check it for mispelling.

I don't know how the "switch" works on Mozilla Translator (from 5.24), but the comments should be readeable in any string: it would simplify the translation process.

Comment 2

[Iacopo Benesperi [:iacchi]]

Attachment: File replacement with comments

Comment 3

[Decathlon]

Attachment: proposal with comments

This is the same file attached by Iacopo with more comments (a comment for every string).
Same request for check as in comment #1.
Thanks in advance.

Comment 4

[Stefan Sitter [:ssitter]]

Comment on attachment 352947 [details] [diff] [review]
proposal with comments

>+# Edit recurrence window -> Recurrence pattern -> Daily repeat rules
> repeatDetailsRuleDaily1=every day

I suggest to use the recommended format for the localization notes <https://developer.mozilla.org/En/Localization_notes>, e.g.

# LOCALIZATION NOTE (repeatDetailsRuleDaily1): comment

Comment 5

[Decathlon]

Attachment: patch v1 with established format for localization notes

Thanks Stefan for your suggestion.
Made required changes.
I don't know if a request for approval1.9.1 must be set. Could you please set the flag if the patch needs it?

Comment 6

[Berend Cornelius]

Comment on attachment 353017 [details] [diff] [review]
patch v1 with established format for localization notes

I find the comments short but also concise so altogether very good. r=berend.

Comment 7

[Berend Cornelius]

patch pushed to comm-central:

http://hg.mozilla.org/comm-central/rev/da54c7e0fb5b

issue is fixed.
I hope I spelled the name of Bas correctly

Comment 8

[Andreas Treumann]

Checked and verified.

Comment 9

[Berend Cornelius]

Decathlon pointed out a mistake that I made when pushing the patch to comm-central: Bas was was not the patch distributor as I wrote in my comment. I am sorry about that.