Closed
Bug 465573
Opened 16 years ago
Closed 16 years ago
Add mochitests for ElementTraversal
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
VERIFIED
FIXED
mozilla1.9.1b3
People
(Reporter: jmaher, Assigned: jmaher)
References
Details
(Keywords: fixed1.9.1)
Attachments
(1 file)
|
19.35 KB,
patch
|
sicking
:
review+
sicking
:
superreview+
|
Details | Diff | Splinter Review |
We need to finish implementing the elementTraversal tests as well as add tests from: http://dev.w3.org/2006/webapi/ElementTraversal/tests/. Attached is a patch for review
|
||
Updated•16 years ago
|
Attachment #348803 -
Attachment is patch: true
Attachment #348803 -
Attachment mime type: application/octet-stream → text/plain
|
|
||
Updated•16 years ago
|
Component: General → Content
Product: Firefox → Core
QA Contact: general → content
|
Assignee | |
Updated•16 years ago
|
Assignee: nobody → jmaher
Status: NEW → ASSIGNED
Attachment #348803 -
Flags: superreview+
Attachment #348803 -
Flags: review+
Adding checkin-needed. I think it makes sense to land this after beta 2. Joel, I think the rest of the process is as follows: * beta 2 builds * joel runs these on at least two platforms just for sanity checking in the mochitest framework * ctalbert checks them in. Sound good?
Keywords: checkin-needed
|
||
Comment 2•16 years ago
|
||
(In reply to comment #1) > Adding checkin-needed. I think it makes sense to land this after beta 2. Tests could land during the freeze; yet, not proceeding unless you say so.
Whiteboard: [c-n: "land this _after_ 191b2"]
I didn't realize we were landing tests during the freeze. I figured that while people were landing patches we shouldn't be mucking with what the test boxes were running. Hell, if you've got time, the inclination and a green tree, feel free to land it. Thanks!
|
|
||
Comment 4•16 years ago
|
||
(In reply to comment #3) Well, there seemed to be a debate related to freeze push yesterday, so we'll see...
Whiteboard: [c-n: "land this _after_ 191b2"]
|
|
||
Comment 5•16 years ago
|
||
Comment on attachment 348803 [details] [diff] [review] element traversal mochitests [Checkin: Comment 5+6 & 7] http://hg.mozilla.org/mozilla-central/rev/a5071bef601d
Attachment #348803 -
Attachment description: element traversal mochitests → element traversal mochitests
[Checkin: Comment 5]
|
|
||
Updated•16 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Flags: in-testsuite+
Keywords: checkin-needed
Resolution: --- → FIXED
Whiteboard: [c-n: baking for 1.9.1]
Target Milestone: --- → mozilla1.9.1b3
|
|
||
Comment 6•16 years ago
|
||
Comment on attachment 348803 [details] [diff] [review] element traversal mochitests [Checkin: Comment 5+6 & 7] http://hg.mozilla.org/mozilla-central/rev/6af9c14f299c bustage fix for changeset a5071bef601d Please, check text format and compilation beforehand.
Attachment #348803 -
Attachment description: element traversal mochitests
[Checkin: Comment 5] → element traversal mochitests
[Checkin: Comment 5 & 6]
|
|
||
Comment 7•16 years ago
|
||
Comment on attachment 348803 [details] [diff] [review] element traversal mochitests [Checkin: Comment 5+6 & 7] http://hg.mozilla.org/releases/mozilla-1.9.1/rev/82574cd23846 (includes both trunk changesets)
Attachment #348803 -
Attachment description: element traversal mochitests
[Checkin: Comment 5 & 6] → element traversal mochitests
[Checkin: Comment 5+6 & 7]
|
|
||
Updated•16 years ago
|
Keywords: fixed1.9.1
Whiteboard: [c-n: baking for 1.9.1]
|
||
Comment 8•16 years ago
|
||
Verified FIXED Tests are in suite and pass on latest trunk & branch Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2a1pre) Gecko/20090601 Minefield/3.6a1pre Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1pre) Gecko/20090601 Shiretoko/3.5pre
Status: RESOLVED → VERIFIED
|
||
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•