465592 - To enable PGO on Thunderbird a module in the Mozilla core needs to have PGO disabled.

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Chris Bishop]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.0.3) Gecko/2008092417 Firefox/3.0.3
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b2pre) Gecko/20081107 Shredder/3.0b1pre

Bug 448515 refers to how there isn't a Profiledbuild option.

In this bug I wrote how I was able to successfully build Thunderbird with PGO but I had to disable PGO in one module in the mozilla core.

In mozilla/modules/lcms/src/Makefile.in I had to add the environment variable ( or make variable, not sure) NO_PROFILE_GUIDED_OPTIMIZE = 1.

My thought is the mozilla core should not have to be modified to allow thunderbird to be built with PGO.  The Thunderbird build configuration should be modified to some how enable PGO for Thunderbird since Firefox can be built with PGO without modifying this particular Makefile.

I am currently working on this problem and need help and direction.  The work I've done so far can be found here. 

http://zenit.senecac.on.ca/wiki/index.php/PGO_Related_Bugs#0.2_Release

Reproducible: Always

Steps to Reproduce:
( html format can be found here - http://zenit.senecac.on.ca/wiki/index.php/PGO_Related_Bugs/Thunderbird )

1.
Modify the file $topsrcdir/mozilla/modules/lcms/src/Makefile.in and add the line NO_PROFILE_GUIDED_OPTIMIZE = 1. 

2.
Configure the .mozconfig in the $topsrcdir for ac_add_options --enable-application=mail and mk_add_options MOZ_CO_PROJECT=mail. My .mozconfig looks like

ac_add_options --enable-application=mail
mk_add_options MOZ_CO_PROJECT=mail
mk_add_options MOZ_MAKE_FLAGS=-j5
ac_add_options --disable-vista-sdk-requirements
ac_add_options --disable-tests
ac_add_options --enable-optimize
ac_add_options --disable-debug

3.
In the $topsrcdir execute the build command make -f client.mk build MOZ_PROFILE_GENERATE=1

4.
After it has finished, Thunderbird needs to be profiled. Run the executable found in $objdir/mozilla/dist/bin and do a few scenarios and close Thunderbird. 

5.
This next step I did not due on Windows and it worked ok. I have to try it and see what happens. I'm told this step has to take place.

In the $topsrcdir execute the build command make -f client.mk clean

6.
In the $topsrcdir execute the build command make -f client.mk build MOZ_PROFILE_USE=1
Actual Results:  
Thunderbird is built with PGO

Comment 1

[Chris Bishop]

Attachment: Patch to disable the LCMS module only if the module is not linked into the xul.dll.

This patch checks if the flag to link other modules into xul library is not set.  If the flag is not set then disable PGO for the lcms module.  This was checked on Windows only.

Comment 2

[(not currently active) Ted Mielczarek]

Comment on attachment 350246 [details] [diff] [review]
Patch to disable the LCMS module only if the module is not linked into the xul.dll.

Don't bother putting the bug number in there, people can use blame to find this bug. We generally only put bug numbers in there if there's followup work to be done. If you'd like to file a bug on figuring out why this breaks in non-libxul PGO builds and fixing it, you could do that and put that bug number here instead. Also, the comment could be a little clearer, just say "Disable PGO for this module in non-libxul builds, where it breaks."

r=me

Comment 3

[Chris Bishop]

Attachment: updated with recommendations [Checkin: Comment 4]

This patch includes the recommendations by Ted.

Comment 4

[Serge Gautherie (:sgautherie)]

Comment on attachment 351620 [details] [diff] [review]
updated with recommendations
[Checkin: Comment 4]

http://hg.mozilla.org/mozilla-central/rev/fc579917e321

Comment 5

[Serge Gautherie (:sgautherie)]

(In reply to comment #4)
> (From update of attachment 351620 [details] [diff] [review])
> http://hg.mozilla.org/mozilla-central/rev/fc579917e321

I added a space at the beginning of the comment.