Closed
Bug 465611
Opened 17 years ago
Closed 17 years ago
npfunctions should take into account different NP_Initialize signature for Mac OS X
Categories
(Core Graveyard :: Plug-ins, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla1.9.1b3
People
(Reporter: jaas, Assigned: jaas)
Details
(Keywords: fixed1.9.1)
Attachments
(2 files)
|
7.79 KB,
patch
|
smichaud
:
review+
jst
:
superreview+
beltzner
:
approval1.9.1+
|
Details | Diff | Splinter Review |
|
4.76 KB,
patch
|
Details | Diff | Splinter Review |
Right now npfunctions.h uses the two-argument form of NP_Initialize in its XP_UNIX section of init functions. Mac OS X uses a one-argument form of NP_Initialize.
The patch here also kills off usage of the void keyword for no-argument signatures in the npapi headers and moves com->org for the test plugin.
Attachment #348841 -
Flags: review?(smichaud)
|
||
Comment 1•17 years ago
|
||
Comment on attachment 348841 [details] [diff] [review]
fix v1.0
Looks fine to me.
Attachment #348841 -
Flags: review?(smichaud) → review+
Attachment #348841 -
Flags: superreview?(jst)
|
||
Updated•17 years ago
|
Attachment #348841 -
Flags: superreview?(jst) → superreview+
Attachment #348841 -
Flags: approval1.9.1?
|
||
Comment 2•17 years ago
|
||
Comment on attachment 348841 [details] [diff] [review]
fix v1.0
a191=beltzner
Attachment #348841 -
Flags: approval1.9.1? → approval1.9.1+
|
||
Comment 4•17 years ago
|
||
Please make sure you have a bug # in commit message in the future. I didn't notice until I had already pushed, so this changeset has no associated bug number.
http://hg.mozilla.org/mozilla-central/rev/f8acae5dc56b
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.1b3
|
||
Updated•16 years ago
|
Keywords: fixed1.9.1
|
||
Updated•3 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•