465662 - remove libreg from toolkit

Status: RESOLVED INVALID

(Toolkit Graveyard :: Build Config, defect)

Description

[Doug Turner (:dougt)]

The only consumer of libreg is browser/migration.  We should consider moving this functionality out of toolkit and basically make the browser makefiles.sh create the makefiles for libreg instead of toolkit.

This is ideal since mobile doesn't need libreg and for windows mobile, we have some build bustages in that code.

Comment 1

[Doug Turner (:dougt)]

Attachment: patch v.1

something like this.

Comment 2

[Phil Ringnalda (:philor)]

(In reply to comment #0)
> The only consumer of libreg is browser/migration.

s/browser/browser,mail,suite,mailnews/

Comment 3

[Doug Turner (:dougt)]

not mobile, songbird.  it would be good to have a configure flag or something.

Comment 4

[(not currently active) Ted Mielczarek]

You could add an AC_SUBST(MOZ_LIBREG) in configure.in, and have apps opt in in their confvars.sh.

Comment 5

[Benjamin Smedberg]

Plugins don't use libreg for pluginreg.dat any more?

Comment 6

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to comment #5)
> Plugins don't use libreg for pluginreg.dat any more?

Doesn't appear to. It uses nsPluginManifestLineReader, which has no dependencies on libreg.

Comment 7

[Doug Turner (:dougt)]

so, can we move this out of toolkit?

Comment 8

[Benjamin Smedberg]

Yes, I think so. We should continue to build the static library always as part of the xulrunner build process, but there's no need to link it to libxul.

Comment 9

[Doug Turner (:dougt)]

bsmedberg, can you take a look at the patch?

Comment 10

[Benjamin Smedberg]

Comment on attachment 348917 [details] [diff] [review]
patch v.1

I think we should build libreg from the XR build system even when it might not be used.

Comment 11

[Doug Turner (:dougt)]

yeah, that removes my motivation from fixing this.  I do not want to build libreg on WINCE.  There were a bunch of problems with libreg building on WINCE and given that we do not use it, I didn't look at fixing them.

Why build something we don't use?

Comment 12

[Benjamin Smedberg]

You don't have to build it on WinCE. I just want it to keep building otherwise because a fair number of apps use it, and getting them each to build it is pretty hard...

Comment 13

[Doug Turner (:dougt)]

it doesn't look like we/fennec needs this any longer.  we are successfully building as is.

Comment 15

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Attachment: disable libreg on CE

Here's a patch to disable it when building on CE.  Doug, I think you're building with --disable-xpinstall, which causes it to not be needed... though now that I think about it, we don't need xpinstall for my use anyway.  However, we may as well fix this so that things don't break if someone doesn't specify the disable.

I don't really agree that we should keep building this for other platforms -- if other apps need it, they should take ownership of it; but disabling it here fixes the immediate problem.

Comment 16

[Doug Turner (:dougt)]

clearing 1.9.1 request

Comment 18

[Marco Castelluccio [:marco]]

This is not exactly a duplicate of that bug, however is useless now :)