465685 - dragged bookmark in bookmarks menu ends up in root folder

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[Peter van der Woude [:Peter6]]

followup from bug 465333

repro:
open bookmarks folder
drag a bookmark

result:
it doesn't land where you put the pointer but ends at the bottom of the root folder

Comment 1

[Luke Iliffe (Harlequin99)]

Blocks bug 225680?

Comment 2

[Damian Shaw [Quan]]

Can confirm on:

Mozilla/5.0 (Windows; U; Windows NT 5.2; en-US; rv:1.9.1b2pre) Gecko/20081119 Minefield/3.1b2pre ID:20081119041246

Comment 3

[Ria Klaassen (not reading all bugmail)]

I believe this is a duplicate of Bug 460666.

Comment 4

[Damian Shaw [Quan]]

(In reply to comment #3)
> I believe this is a duplicate of Bug 460666.

That's similar but it isn't doubled and it isn't in the toolbar either, plus this only just appeared and that bug was filed a month ago.

Comment 5

[Marco Bonardo [:mak]]

Bug 46066 is not related, and should actually not being reproducible in current build.

Comment 6

[Marco Bonardo [:mak]]

ops, i was meaning Bug 460666

Comment 7

[Marco Bonardo [:mak]]

Attachment: patch

we catch the dragdrop event in menu handler, and the drop event in the view.
this change should be enough.

Comment 8

[Asaf Romano (gone)]

Comment on attachment 349034 [details] [diff] [review]
patch

r=mano

Comment 9

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 349034 [details] [diff] [review]
patch

a191b2=beltzner

Comment 10

[Boris Zbarsky [:bzbarsky]]

Pushed http://hg.mozlla.org/mozilla-central/rev/0d95559afc0d

Comment 11

[Marcia Knous [:marcia]]

verified fixed using Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b2pre) Gecko/20081121 Minefield/3.1b2pre. Drag and drop lands where I place the pointer.