Closed Bug 465701 Opened 16 years ago Closed 16 years ago

Birthday field has l12y issue

Categories

(MailNews Core :: Address Book, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla1.9.1b3

People

(Reporter: dev-null, Assigned: dev-null)

References

Details

(Keywords: l12y)

Attachments

(1 file, 1 obsolete file)

Attached patch Patch v1.0 (obsolete) — Splinter Review
Some languages need more labels to localize.
Attachment #348952 - Flags: review?(bugzilla)
Bryan, Josh, does this conflict with any other work we are currently on doing? I think its fine to add these fields.
It should be fine.
Comment on attachment 348952 [details] [diff] [review]
Patch v1.0

+            <label value="&In.label;" disabled="true"/>
...
             <label control="Age" value="&Or.value;" disabled="true"/>
...
+            <label value="&YearsOld.label;" disabled="true"/>

I'm trying to work out why we have disabled="true" here. afaik its not required.

Josh any ideas?
It is not required; I believe it was from a design that Bryan had which was to keep the text gray like the emptytext is in the age and year textboxes.

http://clarkbw.net/designs/birthday-field/birthday_with_year_new.png
Comment on attachment 348952 [details] [diff] [review]
Patch v1.0

I'm happy with this in principle, but please could you drop the disabled="true" from the lines I list below (including the one you haven't changed):

+            <label value="&In.label;" disabled="true"/>
             <label control="Age" value="&Or.value;" disabled="true"/>
+            <label value="&YearsOld.label;" disabled="true"/>
Attachment #348952 - Flags: review?(bugzilla) → review-
Addresses review.
Attachment #348952 - Attachment is obsolete: true
Attachment #352632 - Flags: superreview?(bienvenu)
Attachment #352632 - Flags: review?(bugzilla)
Attachment #352632 - Flags: review?(bugzilla) → review+
Attachment #352632 - Flags: superreview?(bienvenu) → superreview+
Comment on attachment 352632 [details] [diff] [review]
Patch v1.1
[Checkin: Comment 8]

thx for the patch
Keywords: checkin-needed
Comment on attachment 352632 [details] [diff] [review]
Patch v1.1
[Checkin: Comment 8]

http://hg.mozilla.org/comm-central/rev/6af94401b1bc
Attachment #352632 - Attachment description: Patch v1.1 → Patch v1.1 [Checkin: Comment 8]
Assignee: nobody → dev-null
Status: NEW → RESOLVED
Closed: 16 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.1b3
You need to log in before you can comment on or make changes to this bug.