465701 - Birthday field has l12y issue

Status: RESOLVED FIXED

(MailNews Core :: Address Book, defect)

Description

[Atsushi Sakai]

Attachment: Patch v1.0

Some languages need more labels to localize.

Comment 1

[Mark Banner (:standard8)]

Bryan, Josh, does this conflict with any other work we are currently on doing? I think its fine to add these fields.

Comment 2

[Josh Geenen (:pi)]

It should be fine.

Comment 3

[Mark Banner (:standard8)]

Comment on attachment 348952 [details] [diff] [review]
Patch v1.0

+            <label value="&In.label;" disabled="true"/>
...
             <label control="Age" value="&Or.value;" disabled="true"/>
...
+            <label value="&YearsOld.label;" disabled="true"/>

I'm trying to work out why we have disabled="true" here. afaik its not required.

Josh any ideas?

Comment 4

[Josh Geenen (:pi)]

It is not required; I believe it was from a design that Bryan had which was to keep the text gray like the emptytext is in the age and year textboxes.

http://clarkbw.net/designs/birthday-field/birthday_with_year_new.png

Comment 5

[Mark Banner (:standard8)]

Comment on attachment 348952 [details] [diff] [review]
Patch v1.0

I'm happy with this in principle, but please could you drop the disabled="true" from the lines I list below (including the one you haven't changed):

+            <label value="&In.label;" disabled="true"/>
             <label control="Age" value="&Or.value;" disabled="true"/>
+            <label value="&YearsOld.label;" disabled="true"/>

Comment 6

[Atsushi Sakai]

Attachment: Patch v1.1 [Checkin: Comment 8]

Addresses review.

Comment 7

[David :Bienvenu]

Comment on attachment 352632 [details] [diff] [review]
Patch v1.1
[Checkin: Comment 8]

thx for the patch

Comment 8

[Serge Gautherie (:sgautherie)]

Comment on attachment 352632 [details] [diff] [review]
Patch v1.1
[Checkin: Comment 8]

http://hg.mozilla.org/comm-central/rev/6af94401b1bc