465771 - Port bug 391728 (disabled plugin placeholder) UI to SeaMonkey

Status: VERIFIED FIXED

(SeaMonkey :: UI Design, defect)

Description

[Robert Kaiser]

bug 391728 added some Firefox-specific UI stuff that SeaMonkey probably needs to port.

Comment 1

[Philip Chee]

Also Bug 462965 - Land disabled plugin and blocked plugin icons

Comment 2

[Robert Kaiser]

Bug 484188 adds tests for plugins, one part I marked todo() there is probably connected with this.

Comment 4

[[e-mail]]

Attachment: Proposed patch

Only picking KaiRo because of test changes. Feel free to redirect if necessary.

Comment 5

[Robert Kaiser]

Comment on attachment 404022 [details] [diff] [review]
Proposed patch

Thanks for taking this on, works fine!

Comment 6

[Robert Kaiser]

Comment on attachment 404022 [details] [diff] [review]
Proposed patch

>+            var theEM = Components.classes["@mozilla.org/appshell/window-mediator;1"]
>+                                  .getService(Components.interfaces.nsIWindowMediator)
>+                                  .getMostRecentWindow("Extension:Manager");
>+
>+            if (theEM) {
>+              theEM.focus();
>+              theEM.showView("plugins");
>+              return;
>+            }
>+
>+            const EMURL = "chrome://mozapps/content/extensions/extensions.xul";
>+            const EMFEATURES = "all,dialog=no";
>+            window.openDialog(EMURL, "", EMFEATURES, "plugins");

As a note, you probably could have gone through toEM("plugins") here as well, but I'll leave it up to you which way you like better.

Comment 7

[[e-mail]]

(toEM isn't guaranteed to be available from notification.xml)

Comment 8

[[e-mail]]

Pushed changeset 12859ee80820 to comm-central.

Comment 9

[lenochod]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1.4pre) Gecko/20091002 SeaMonkey/2.0pre

It's work fine, now.