465824 - Flashblock placeholders not visible

Status: VERIFIED FIXED

(Camino Graveyard :: Annoyance Blocking, defect)

Description

[Christopher Henderson]

Latest builds of Camino (2.0b1pre (1.9.0.5pre 2008111900)), with Flashblock enabled, do not show the placeholder. Thus, the Flash objects cannot be displayed. Still looking for a regression date.

Comment 1

[Christopher Henderson]

This bug turns up between the nightly builds 2008-11-18-00-2.0-M1.9 and 2008-11-19-00-2.0-M1.9.

Comment 2

[philippe (part-time)]

I get the following errors :

On any given youtube page:
8:23 AM: [JavaScript Error: "uncaught exception: [Exception... "Component is not available"  nsresult: "0x80040111 (NS_ERROR_NOT_AVAILABLE)"  location: "JS frame :: chrome://flashblock/content/flashblock.xml ::  :: line 271"  data: no]" {file: "http://s.ytimg.com/yt/js/base_all_with_bidi-vfl64428.js" line: 3855}]
8:23 AM: [JavaScript Error: "uncaught exception: [Exception... "Component is not available"  nsresult: "0x80040111 (NS_ERROR_NOT_AVAILABLE)"  location: "JS frame :: chrome://flashblock/content/flashblock.xml ::  :: line 271"  data: no]" {file: "http://s.ytimg.com/yt/js/base_all_with_bidi-vfl64428.js" line: 3855}]

On ElPais.com (one flash movie, ad-blocking on)
8:26 AM: [JavaScript Error: "uncaught exception: [Exception... "Component is not available"  nsresult: "0x80040111 (NS_ERROR_NOT_AVAILABLE)"  location: "JS frame :: chrome://flashblock/content/flashblock.xml ::  :: line 271"  data: no]"]

Comment 3

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Bonsai: http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=Camino&branch=HEAD&branchtype=match&dir=&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2008-11-18+00%3A00&maxdate=2008-11-19+00%3A00&cvsroot=%2Fcvsroot

Based on bug 463839 comment 3, this is probably from the landing of bug 370461 on 1.9.0, and the fix should be for us to upgrade our internal copy of Flashblock.

I'll work up a patch.

Comment 4

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Attachment: Upgrade from 1.5.5-unstable to 1.5.7

hendy, do you still crash on quitting with this patch?  What sites were you visting?

I saw some malloc_error messages once on quitting, but I was never able to reproduce them (using http://www.adobe.com/shockwave/welcome/ as a testcase).

The only thing I see now is this warning: 

> Nov 19 19:20:09 Qalaat-Samaan [0x0-0x125125].org.mozilla.camino[26636]: WARNING: Components.lookupMethod deprecated, use Components.utils.lookupMethod: file /Users/smokey/Camino/dev/trunk/mozilla/js/src/xpconnect/src/xpccomponents.cpp, line 4079

(and nothing in static builds)

Philip, could you also have a look and make sure this seems reasonable/correct for an upgrade from 1.5.5+ (the fix for bug 418489) to 1.5.7?

Comment 5

[philippe (part-time)]

Patch works fine here, no crashes on quit with a YouTube movie open/playing (so far...).
No annoying messages in console.log
(static opt build)

Comment 6

[Philip Chee]

I've compared attachment 349087 [details] [diff] [review] with our CVS and your patch looks consistent with
the changes in our CVS between 1.8.2.26 and 1.8.2.29 (current). q.v.:
<http://www.mozdev.org/source/browse/flashblock/source/content/flashblock/flashblock.xml.diff?r1=1.8.2.26;r2=1.8.2.29;only_with_tag=FLASHBLOCK_1_5_CLEANUP_BRANCH>

Comment 7

[Christopher Henderson]

Comment on attachment 349087 [details] [diff] [review]
Upgrade from 1.5.5-unstable to 1.5.7

Placeholders are visible again, and no crashes on a fresh pull+patch.

Comment 8

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Comment on attachment 349087 [details] [diff] [review]
Upgrade from 1.5.5-unstable to 1.5.7

Thanks, guys.

Philip, do you know off-hand if there's a current bug about Flash objects being duplicated when you enable Flashblock (i.e., load the test page, see the Flash, enable Flashblock, Flash gets the blocked image but the Flash animation also appears, unblocked, to the right)?  Or is this an artifact of the way Camino enables/disables Flashblock—it's live in Camino 2.x, whereas it seems to require a page reload in Firefox.  (This is an existing problem, not something new in 1.5.7.)

Comment 9

[Stuart Morgan]

Comment on attachment 349087 [details] [diff] [review]
Upgrade from 1.5.5-unstable to 1.5.7

rs=smorgan

Comment 10

[Philip Chee]

> Philip, do you know off-hand if there's a current bug about Flash objects being
> duplicated when you enable Flashblock (i.e., load the test page, see the Flash,
> enable Flashblock, Flash gets the blocked image but the Flash animation also
> appears, unblocked, to the right)?

I don't know if there is a specific bug number, but I've seen that happen with standard Flashblock+Firefox. According to bz it's got something to do with the way frames are repainted or re-parented (or torn down and re-initialized, the technical details are over my head). If you look at such a case in the DOMi, the duplicate unblocked flash doesn't appear in the DOM tree view at all. And of course if it isn't in the DOM, it's invisible to Flashblock.

Comment 11

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Checked in on cvs trunk.  The Core bug that caused this landed on 1_8, too, so we'll probably want this for 1.6.6. 

(In reply to comment #10)
> I don't know if there is a specific bug number, but I've seen that happen with
> standard Flashblock+Firefox. According to bz it's got something to do with the
> way frames are repainted or re-parented (or torn down and re-initialized, the
> technical details are over my head). If you look at such a case in the DOMi,
> the duplicate unblocked flash doesn't appear in the DOM tree view at all. And
> of course if it isn't in the DOM, it's invisible to Flashblock.

Thanks; I vaguely remember reading a bug (or at least bug comment) about that at some point, so I'll hopefully assume someone's filed it somewhere ;-)

Comment 12

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Landed on the MOZILLA_1_8_BRANCH for 1.6.6 (placeholders are indeed broken there, and the upgrade does indeed fix the brokenness and does not regress bug 418489).

Comment 13

[philippe (part-time)]

Verified Fixed with Version 2.0b1pre (1.9.0.5pre 2008112100)