Closed
Bug 465878
Opened 17 years ago
Closed 17 years ago
Recreating Preferences Manager on shutdown
Categories
(Camino Graveyard :: Preferences, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Camino2.0
People
(Reporter: bugzilla-graveyard, Assigned: bugzilla-graveyard)
References
Details
(Keywords: regression)
Attachments
(1 file)
|
1.06 KB,
patch
|
stuart.morgan+bugzilla
:
superreview+
|
Details | Diff | Splinter Review |
Smokey thinks smfr fixed this at least once before, though I can't find anything.
Debug builds, as of sometime in the last couple months, are logging "Recreating preferences manager on shutdown!" when quit. I don't know if it's a serious problem, but I'm pretty sure the cause is this, from the patch on bug 384689:
- (void) dealloc
{
[[NSNotificationCenter defaultCenter] removeObserver:self];
+ [[PreferenceManager sharedInstance] removeObserver:self forPref:kGeckoPrefInlineLocationBarAutocomplete];
[self cleanup];
[super dealloc];
}
Do we actually need to remove the Gecko pref observer since the PreferenceManager has already been destroyed at that point? I assumed we did, but maybe we don't.
|
||
Comment 1•17 years ago
|
||
Oops, that's definitely bad. We should be using sharedInstanceDontCreate instead.
Target Milestone: --- → Camino2.0
|
Assignee | |
Comment 2•17 years ago
|
||
That oughta do it. Sorry 'bout that.
Assignee: nobody → cl-bugs-new
Status: NEW → ASSIGNED
Attachment #349116 -
Flags: superreview?(stuart.morgan+bugzilla)
|
|
||
Updated•17 years ago
|
Attachment #349116 -
Flags: superreview?(stuart.morgan+bugzilla) → superreview+
|
|
||
Comment 3•17 years ago
|
||
Comment on attachment 349116 [details] [diff] [review]
fix v1.0
sr=smorgan
Chickens wrangled.
Blocks: 384689
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Keywords: regression
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•