46592 - [FIX] Search menu items need some rewording

Status: VERIFIED FIXED

(SeaMonkey :: Search, defect, P1)

Description

[Blake Ross]

Build ID: 2000072608 WinNT 4

Steps to Reproduce:

(1) Show My Sidebar (if not already shown)
(2) Switch to the Search tab (if not already the active tab)
(3) Search for anything (e.g. 'test')
(4) Right click on one of the results in the results tree

Two menu items appear:
"Filter out this URL from all search results"
"Filter out this website from all search res..." (it's too long, gets cut off)

As far as I can tell (unless the second menu item is REALLY long and the rest 
of its description is cut off), these two items serve the same purpose, so one 
should go.  Personally, I think the latter item is more user-friendly (how many 
users understand what an "URL" is?), but it looks terrible cut-off like that.

Comment 1

[german]

to be honest, I have no clue where these come from. I haven't even seen a spec 
for this feature. I suggest we forward this to Ben who has in the past been 
involved in both search  and browser UI stuff. (adding to cc)

Comment 2

[Robert John Churchill]

The two items serve different purposes.  The former filters out a single URL so 
that it will never be shown again in search results while the latter filters out 
an entire web domain.

Feel free to dream up better phrasing.

Comment 3

[verah (gone)]

Matt, you can reassign this to me for better phrasing. German, any opinions? How 
about:
"Don't include this url in search"
"Don't include this domain in search"

I'm not sure we can do anything about the techy sound of these items -- without 
becoming hopelessly imprecise.

Comment 4

[german]

vera, there is something missing that says this will affect subsequent 
searches...(that is if I understand correctly what this feature is supposed to 
do)

Comment 5

[verah (gone)]

Yeah, I know. Keeping it short is a problem, though. Here's another try:

"Exclude this url from next search"
"Exclude this domain from next search"

Comment 6

[Robert John Churchill]

"next search" is rather vague...  the URL/domain in question is excluding from 
all future search result sets.

Comment 7

[verah (gone)]

Is that really what it's doing? I thought it would exclude them if the present 
search was run again.

If it really is all future searches, then how about:

"Exclude this url from future searches"
"Exclude this domain from future searches"

Comment 8

[Blake Ross]

I think your last suggestion is the best yet.  May want to capitalize 'url', 
though.  I'm afraid that (though this is a simple but handy feature) many users 
won't use the feature for lack of understanding it, but I, too, can't think of 
a non-techy way to say it.  Reassigning to vera to finalize the wording and 
then I'll check it in.

Comment 9

[verah (gone)]

Yikes, I've been doing this stuff too long. "URL" should definitely be 
capitalized. So:

"Exclude this URL from future searches"
"Exclude this domain from future searches"

Reassigning back to Blake.

Comment 10

[Blake Ross]

Thanks, Vera.   I'll check it in soon.

Comment 11

[timeless]

Dumb question, how do I unignore? My little sister just ignored my favorite 
websites! </hypothetical>

Comment 12

[Blake Ross]

Timeless: Damn good question. File a bug.

Comment 13

[Robert John Churchill]

No need for a bug. If you have anything filtered, a new context menu command 
becomes available to remove filters.

Comment 14

[Blake Ross]

All filters?  What if I just want to remove the filter on a single website?

Comment 15

[verah (gone)]

Checking status -- there's a UI freeze coming up (9/15) -- can this fix be 
checked in before that?

Comment 16

[Blake Ross]

Attachment: patch

Comment 17

[Claudius Gayle]

fyi, the how do I unfilter a single URL bug is bug 52316

Comment 18

[Brendan Eich [:brendan]]

OK, better wording -- a=[e-mail] on that -- but why is this big
honking C++ file full of stuff that could be in JS and use XPConnect to script
lower-level components like string bundles?

/be

Comment 19

[Blake Ross]

Brendan: I've already reported that as bug 46592; see also rjc's comment there.

Comment 20

[Blake Ross]

I meant bug 52308, of course..

Comment 21

[Blake Ross]

fix checked in

Comment 22

[Claudius Gayle]

VERIFIED Fixed with 20001108 builds. i do notice however that the text of the
relevant context menuitems are cropped, which is rather irksome. Is there some
hard limit on context menu width?