465940 - crash [@ nsMsgDBView::SecondarySort(unsigned int, nsISupports*, unsigned int, nsISupports*, viewSortInfo*)] - [@ nsMsgDBView::FnSortIdKey]

Status: VERIFIED WORKSFORME

(MailNews Core :: Backend, defect)

Description

[Wayne Mery (:wsmwk)]

topcrash pulled from crash-stats

crash [@ nsMsgDBView::SecondarySort(unsigned int, nsISupports*, unsigned int, nsISupports*, viewSortInfo*)]

all are build 2008100600, aka 3.0a3.

only crash with comment is ... I created a search folder that got all messages from trash and sent and inbox in order to test searching across all folders. It was working for a bit but now it crashed when I was clicking different sorts and clicking the "x" next to the search field to return to regular view. Now when I just restarted thunderbird and clicked on the search folder, it crashed immediately.
bp-4b78259c-ab22-11dd-a2bf-001a4bd43ef6 Mac
nsMsgDBView::SecondarySort	nsMsgDBView.cpp:3722
nsMsgDBView::FnSortIdKeyPtr	nsMsgDBView.cpp:3288
nsMsgDBView::GetInsertIndexHelper	nsMsgDBView.cpp:4690
nsMsgDBView::GetInsertIndex	nsMsgDBView.cpp:4722
nsMsgXFVirtualFolderDBView::InsertHdrFromFolder	nsMsgXFVirtualFolderDBView.cpp:200
nsMsgXFVirtualFolderDBView::OnSearchHit	nsMsgXFVirtualFolderDBView.cpp:308
nsMsgSearchSession::AddSearchHit	nsMsgSearchSession.cpp:580
nsMsgSearchOfflineMail::AddResultElement	nsMsgLocalSearch.cpp:780
nsMsgSearchOfflineMail::Search	nsMsgLocalSearch.cpp:732
nsMsgSearchSession::TimeSliceSerial	nsMsgSearchSession.cpp:692
nsMsgSearchSession::StartTimer	nsMsgSearchSession.cpp:550
nsMsgSearchSession::BeginSearching	nsMsgSearchSession.cpp:443
nsMsgSearchSession::Search	nsMsgSearchSession.cpp:271 

bp-78a8750e-1a68-456d-ae35-5aca20081119 windows

Comment 1

[David :Bienvenu]

Can we see if this occurs in builds after the new view threading stuff landed? I've fixed several issues like this along with that work.

Comment 2

[Wayne Mery (:wsmwk)]

Unfortunately there are currently no trunk crashes with this signature, so I don't think it will be possible near term to tell if your recent fixes will have an impact on this crasher, if it still exists.

Summary:

The stats and dates support at least these possibilities
1. the bug was very short lived, and lives only in 3.0a3
2. the bug isn't manifest for some environmental reason for those using trunk
3. the patch was pulled from trunk after branching 3.0a3

It's certainly very odd there are no crashes on trunk since 3.0a3 shipped, and the simplest conclusion is the crash is gone, and this is certainly supported by the crash stats.  OTOH, given the full range of  possibilities (and the checkin query below) I don't think we can tell for sure until 3.0b1 ships and we get a new set of broad based statistics. 

Detail:
- only one crash in nightly builds since 9 weeks for nsMsgDBView::SecondarySort bp-9cebea0f-90cb-11dd-b02f-001a4bd43ef6 build date 20081002
- iirc 3.0a3 pull was 2008-10-03
- patches 10/1/08-10/3/08 don't show any crash fixes http://hg.mozilla.org/comm-central/pushloghtml?startdate=10%2F02%2F2008+00%3A01&enddate=10%2F04%2F2008+00%3A01enddate=10%2F04%2F2008+11%3A38

Comment 3

[Wayne Mery (:wsmwk)]

last build with crash sig in the last 2 months is some wacko using  3.0b1pre. [1]. so this is gone unless it lives on as some other stack signature, or is rarer than rare.  

But there is one crash sig where it's near top of stack
nsMsgDBFolder::GetMessageHeader(unsigned int, nsIMsgDBHdr**)  (no bug report)
bp-d4f47f30-cb63-4531-a579-bd1f42100903 v3.1.2
0	AppKit	-[NSWindow sendEvent:]	
1	thunderbird-bin	nsMsgDBFolder::GetMessageHeader	mailnews/base/util/nsMsgDBFolder.cpp:4971
2	thunderbird-bin	nsMsgDBView::SecondarySort	mailnews/base/src/nsMsgDBView.cpp:4032
3	thunderbird-bin	nsMsgDBView::FnSortIdKey	mailnews/base/src/nsMsgDBView.cpp:3562
4	libxpcom_core.dylib	NS_QuickSort	nsQuickSort.cpp:113
5	libxpcom_core.dylib	NS_QuickSort	nsQuickSort.cpp:172
6	libxpcom_core.dylib	NS_QuickSort	nsQuickSort.cpp:172
7	libxpcom_core.dylib	NS_QuickSort	nsQuickSort.cpp:172
8	libxpcom_core.dylib	NS_QuickSort	nsQuickSort.cpp:172
9	libxpcom_core.dylib	NS_QuickSort	nsQuickSort.cpp:172
10	thunderbird-bin	nsMsgDBView::Sort	mailnews/base/src/nsMsgDBView.cpp:4299
11	thunderbird-bin	nsMsgThreadedDBView::Sort	mailnews/base/src/nsMsgThreadedDBView.cpp:387
12	libxpcom_core.dylib	NS_InvokeByIndex_P	xpcom/reflect/xptcall/src/md/unix/xptcinvoke_unixish_x86.cpp:179
13	thunderbird-bin	XPCWrappedNative::CallMethod	js/src/xpconnect/src/xpcwrappednative.cpp:2722
14	thunderbird-bin	XPC_WN_CallMethod	js/src/xpconnect/src/xpcwrappednativejsops.cpp:1740 



[1] bp-b6432d10-741f-4efd-b291-2c46d2100804
0		@0x32d1187	
1	eudora.exe	nsMsgDBView::SecondarySort	nsMsgDBView.cpp:3933
2	eudora.exe	nsMsgDBView::FnSortIdUint32	nsMsgDBView.cpp:3478
3	xpcom_core.dll	NS_QuickSort	nsQuickSort.cpp:135
4	eudora.exe	nsMsgDBView::Sort	nsMsgDBView.cpp:4159
5	eudora.exe	nsMsgThreadedDBView::Sort	nsMsgThreadedDBView.cpp:385

Comment 4

[Wayne Mery (:wsmwk)]

declaring this dead - there are no crashes on 1.9.2 branch or newer with signature nsMsgDBView::SecondarySort(unsigned int, nsISupports*, unsigned int, nsISupports*, viewSortInfo*). And no crashes in last 20 days with substring of "nsMsgDBView::SecondarySort"

Comment 5

[Wayne Mery (:wsmwk)]

found an example in v3.1.15 for bp-96ab91da-6c97-45bf-bc96-6a07a2111025
[@ nsCOMPtr_base::assign_from_qi(nsQueryInterface, nsID const&) | nsMsgDBView::SecondarySort(unsigned int, nsISupports*, unsigned int, nsISupports*, viewSortInfo*) ] 

no crashesfor anything newer ... no v5, v6, v7, ..

Note: all 4 crashes found in past 9 months have been Mac.