466009 - Calendar property page is missing Cancel/Ok

Status: RESOLVED FIXED

(Calendar :: General, defect)

Description

[Daniel Boelzle [:dbo]]

Seems the dialog is too small.

Comment 1

[Stefan Sitter [:ssitter]]

Works for me using Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b2pre) Gecko/20081120 Calendar/1.0pre (BuildID: 20081120121029).

Comment 2

[Pete Riley]

I had a similar problem (bug 453686 - "Calendar Properties dialog is cropped on right side" with Lightning 0.9pre).  I'm not sure if anyone ever discovered the cause of the bug.  Unfortunately I don't have time to deal with Shredder yet so I can't test it with the current nightly.

Comment 3

[Daniel Boelzle [:dbo]]

Attachment: resizable dialogs

Seems that (in my case) the properties dialog had a small persistent size that I couldn't fix. I think it makes sense to have resizable dialogs here, e.g. in case of long email identities. IMO the same applies for the calendar creation wizard.

Comment 4

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Comment on attachment 350319 [details] [diff] [review]
resizable dialogs

Are you sure this is the right solution? In light of backing out bug 394195, I think making the dialog resizable is not the right solution...

Comment 5

[Daniel Boelzle [:dbo]]

Philipp could you elaborate why you don't think the dialog should be resizable? Email identities could be quite long, and sizeToContent() doesn't seem to cover them thoroughly. I agree the size shouldn't be persistent, but since it's been persistent for quite some time, we either need to use a new id or leave it persistent to not bug users that need to resize their dialog, like me ;-)

Comment 6

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Attachment: Fix - v2

Id prefer a patch like this: Dont persist any dimension attributes, but make the dialog resizable. This way the dialog doesnt have strange sizes if the beginner user accidentally resizes the window and then closes it.

We may also want to set the minimum dimensions on load, i.e from the boxObject just after sizeToContent() has been called. This way the user will not accidentally make the window smaller than it should be. Ill leave this up to you.

Comment 7

[Daniel Boelzle [:dbo]]

Comment on attachment 354675 [details] [diff] [review]
Fix - v2

I leave minimal sizes for coming bugs; think this patch is sufficient.

r=dbo

Comment 8

[Daniel Boelzle [:dbo]]

Pushed to comm-central <http://hg.mozilla.org/comm-central/rev/967068fc2d02>

-> FIXED

Comment 9

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

These bugs are likely targeted at Lightning 1.0b1, not Lightning 1.0. If this change was done in error, please adjust the target milestone to its correct value. To filter on this bugspam, you can use "lightning-10-target-move".