Open Bug 466018 Opened 17 years ago Updated 10 years ago

Would be nice for hgweb annotate to show checkin comments (with linkified bugs)

Categories

(Developer Services :: Mercurial: hg.mozilla.org, defect)

Product:
Developer Services
Component:
Mercurial: hg.mozilla.org
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
REOPENED

People

(Reporter: bzbarsky, Unassigned)

Details

(Whiteboard: [kanban:engops:https://mozilla.kanbanize.com/ctrl_board/6/1142])

In bonsai blame, hovering over a revision number shows a little popup with the checkin comment, with the bug number linkified. It would be really nice if hgweb annotate did something similar.
This information wasn't available in the templates, but will be in the next released version (which should be released soon), so then this can be fixed by a change in Mozilla's hgweb templates.
So is this possible now?
Yes, it should now be possible.
So we just need to replace http://hg.mozilla.org/hgcustom/hg_templates/file/a56fa3e671a4/gitweb/map#l27 by http://selenic.com/repo/hg-stable/annotate/45b48be6b910/mercurial/templates/gitweb/map#l89, right? (See this in action with the latter url). Note: <a (...) title="{node|short}: {desc|escape|firstline}"
OS: Mac OS X → All
Hardware: x86 → All
Been working on getting hgstage back up to speed. I've got this change in testing and it seems to work fine: http://hgstage.mozilla.org/mozilla-central/annotate/7c86d9484795/README.txt If it looks good to you guys we'll make this change when we upgrade hg this Friday.
Assignee: nobody → cshields
This was done in today's upgrade.
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Except the bug number is not linkified... That's not really what this bug was about: the idea is to be able to click through to the bug that introduced the code in question!
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
And in particular, you can't do what this bug is asking for via title attributes. You need either some careful markup with :hover selectors or script.
It sounds like the newer version of hg gives us enough data to do this, we'd just need to write some JS to make it happen.
going to unassign this, if someone wants to write the JS to make it happen we can deploy it.
Assignee: cshields → nobody
Product: mozilla.org → Release Engineering
Product: Release Engineering → Developer Services
Whiteboard: [kanban:engops:https://kanbanize.com/ctrl_board/6/269]
Whiteboard: [kanban:engops:https://kanbanize.com/ctrl_board/6/269] → [kanban:engops:https://mozilla.kanbanize.com/ctrl_board/6/1131] [kanban:engops:https://kanbanize.com/ctrl_board/6/269]
Whiteboard: [kanban:engops:https://mozilla.kanbanize.com/ctrl_board/6/1131] [kanban:engops:https://kanbanize.com/ctrl_board/6/269] → [kanban:engops:https://mozilla.kanbanize.com/ctrl_board/6/1139] [kanban:engops:https://kanbanize.com/ctrl_board/6/269]
Whiteboard: [kanban:engops:https://mozilla.kanbanize.com/ctrl_board/6/1139] [kanban:engops:https://kanbanize.com/ctrl_board/6/269] [kanban:engops:https://mozilla.kanbanize.com/ctrl_board/6/1142] [kanban:engops:https://kanbanize.com/ctrl_board/6/269] → [kanban:engops:https://mozilla.kanbanize.com/ctrl_board/6/1142] [kanban:engops:https://kanbanize.com/ctrl_board/6/269] [kanban:engops:https://mozilla.kanbanize.com/ctrl_board/6/1141] [kanban:engops:https://kanbanize.com/ctrl_board/6/269]
Whiteboard: [kanban:engops:https://mozilla.kanbanize.com/ctrl_board/6/1141] [kanban:engops:https://kanbanize.com/ctrl_board/6/269]
Whiteboard: [kanban:engops:https://mozilla.kanbanize.com/ctrl_board/6/1142]
You need to log in before you can comment on or make changes to this bug.