Closed Bug 466072 Opened 15 years ago Closed 15 years ago

Remove unused in-browser EULA prompt

Categories

(Firefox :: General, defect, P2)

Product:
Firefox
Component:
General
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 3.5

People

(Reporter: Dolske, Assigned: Dolske)

References

Details

(Keywords: fixed1.9.1)

Attachments

(1 file)

Patch v.1
26.52 KB, patch
beltzner
: review+
beltzner
: approval1.9.1+
dveditz
: approval1.9.0.6-
Details | Diff | Splinter Review
Attached patch Patch v.1 — — Splinter Review 
Bug 456439 landed the about:rights implementation, and changed the fallback user interaction from "display a EULA and require acceptance" to "show a notification bar for about:rights". Bug 462254 then removed the EULAs in the installers.

456439 should have also removed the now-dead support for displaying a EULA at runtime, since the code for invoking it no longer exists.
Attachment #349319 - Flags: review?(gavin.sharp)
Attachment #349319 - Flags: approval1.9.1?
Note that this essentially completes a backout of the FF2 EULA landing from bug 349068. /browser/EULA predates even that, but has been deadwood since bug 348741 switched to using RTF in the Windows installer, and then bug 349551 removed its use in the build.
Flags: blocking-firefox3.1+
Priority: -- → P2
Assignee: nobody → dolske
Comment on attachment 349319 [details] [diff] [review]
Patch v.1

r+a=beltzner
Attachment #349319 - Flags: review?(gavin.sharp)
Attachment #349319 - Flags: review+
Attachment #349319 - Flags: approval1.9.1?
Attachment #349319 - Flags: approval1.9.1+
Pushed http://hg.mozilla.org/mozilla-central/rev/3f327adb4b19
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Comment on attachment 349319 [details] [diff] [review]
Patch v.1

a1906? -- Just removing deadwood, shouldn't have any impact.
Attachment #349319 - Flags: approval1.9.0.6?
Comment on attachment 349319 [details] [diff] [review]
Patch v.1

Leaving well enough alone here, unless Axel wants it.
Attachment #349319 - Flags: approval1.9.0.6? → approval1.9.0.6-
Target Milestone: Firefox 3.1 → Firefox 3.5
You need to log in before you can comment on or make changes to this bug.