Closed
Bug 466086
Opened 16 years ago
Closed 16 years ago
Remove unused safebrowsing phishing EULA
Categories
(Toolkit :: Safe Browsing, defect)
Toolkit
Safe Browsing
Tracking
()
RESOLVED
FIXED
Firefox 3.6a1
People
(Reporter: Dolske, Assigned: Dolske)
References
Details
(Keywords: fixed1.9.1)
Attachments
(1 file)
|
21.74 KB,
patch
|
Gavin
:
review+
beltzner
:
approval1.9.1+
|
Details | Diff | Splinter Review |
Searching for "EULA" in the tree shows a number of results related to the anti-phishing code. After poking around, I can't find any place that the code / EULA is actually shown. It looks like bug 388652 removed the code that invoked the EULA display when switching safebrowsing providers or type.
Found while looking for any remaining post-bug 456439 cleanup.
Attachment #349340 -
Flags: review?(gavin.sharp)
|
Assignee | |
Updated•16 years ago
|
Whiteboard: [needs review gavin]
|
||
Updated•16 years ago
|
Target Milestone: Firefox 3.1 → Firefox 3.5
|
||
Updated•16 years ago
|
Attachment #349340 -
Flags: review?(gavin.sharp) → review+
|
|
||
Updated•16 years ago
|
Whiteboard: [needs review gavin]
|
|
Assignee | |
Updated•16 years ago
|
Assignee: nobody → dolske
Target Milestone: Firefox 3.5 → Firefox 3.6a1
|
|
Assignee | |
Updated•16 years ago
|
Attachment #349340 -
Flags: approval1.9.1?
|
|
Assignee | |
Comment 1•16 years ago
|
||
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Whiteboard: [needs 1.9.1 landing]
|
||
Comment 2•16 years ago
|
||
May I suggest changing "Component" from "General" to "Phishing Protection"?
|
||
Comment 3•16 years ago
|
||
Comment on attachment 349340 [details] [diff] [review]
Patch v.1
a191=beltzner
Attachment #349340 -
Flags: approval1.9.1? → approval1.9.1+
|
|
Assignee | |
Comment 4•16 years ago
|
||
Component: General → Phishing Protection
Keywords: fixed1.9.1
QA Contact: general → phishing.protection
Whiteboard: [needs 1.9.1 landing]
|
|
||
Comment 5•16 years ago
|
||
It would have been best to avoid landing this on the branch, since it removes localized files in en-US, which causes unnecessary work for localizers now that we're string frozen.
|
||
Updated•11 years ago
|
Product: Firefox → Toolkit
You need to log in
before you can comment on or make changes to this bug.
Description
•