Closed Bug 466086 Opened 11 years ago Closed 11 years ago

Remove unused safebrowsing phishing EULA

Categories

(Toolkit :: Safe Browsing, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 3.6a1

People

(Reporter: Dolske, Assigned: Dolske)

References

Details

(Keywords: fixed1.9.1)

Attachments

(1 file)

Attached patch Patch v.1Splinter Review
Searching for "EULA" in the tree shows a number of results related to the anti-phishing code. After poking around, I can't find any place that the code / EULA is actually shown. It looks like bug 388652 removed the code that invoked the EULA display when switching safebrowsing providers or type.

Found while looking for any remaining post-bug 456439 cleanup.
Attachment #349340 - Flags: review?(gavin.sharp)
Whiteboard: [needs review gavin]
Target Milestone: Firefox 3.1 → Firefox 3.5
Attachment #349340 - Flags: review?(gavin.sharp) → review+
Whiteboard: [needs review gavin]
Assignee: nobody → dolske
Target Milestone: Firefox 3.5 → Firefox 3.6a1
Attachment #349340 - Flags: approval1.9.1?
Pushed http://hg.mozilla.org/mozilla-central/rev/d6d899039252
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [needs 1.9.1 landing]
May I suggest changing "Component" from "General" to "Phishing Protection"?
Comment on attachment 349340 [details] [diff] [review]
Patch v.1

a191=beltzner
Attachment #349340 - Flags: approval1.9.1? → approval1.9.1+
Pushed to 191: http://hg.mozilla.org/releases/mozilla-1.9.1/rev/dd6d728a0108
Component: General → Phishing Protection
Keywords: fixed1.9.1
QA Contact: general → phishing.protection
Whiteboard: [needs 1.9.1 landing]
It would have been best to avoid landing this on the branch, since it removes localized files in en-US, which causes unnecessary work for localizers now that we're string frozen.
Product: Firefox → Toolkit
Depends on: 1502451
You need to log in before you can comment on or make changes to this bug.