Extra separator in View menu

VERIFIED FIXED in 1.0b1

Status

defect
--
minor
VERIFIED FIXED
11 years ago
8 years ago

People

(Reporter: gkw, Assigned: Fallen)

Tracking

unspecified
1.0b1

Details

Attachments

(2 attachments)

(Reporter)

Description

11 years ago
Posted patch patch-v1Splinter Review
There is an extra separator in the View Menu. The patch should fix the issue.
Attachment #349432 - Flags: review?(philipp)
(Reporter)

Comment 1

11 years ago
screenshot.
(Reporter)

Comment 2

11 years ago
mschroeder rightly points out that there is now a lack of separator in Lightning / Task mode with the patch applied.

Thoughts? (I'm thinking it's good to have an all-out relook of menuitems in a new look Thunderbird with integrated calendar, along with comprehensively refactored / audited shortcuts and accesskeys)
Flags: tb-integration?
Comment on attachment 349432 [details] [diff] [review]
patch-v1

We need some mode-magic for <menuseparator id="before-today-pane"/>
, and a small change to <menuseparator id="before-task-View-Section" mode="mail,calendar,task"/>.
Attachment #349432 - Flags: review?(philipp) → review-
(Reporter)

Comment 4

11 years ago
(In reply to comment #3)
> (From update of attachment 349432 [details] [diff] [review])
> We need some mode-magic for <menuseparator id="before-today-pane"/>
> , and a small change to <menuseparator id="before-task-View-Section"
> mode="mail,calendar,task"/>.

Change to <menuseparator id="before-today-pane" add mode="calendar,task"/>?

I'm not so sure how to change before-task-View-Section.
(Reporter)

Comment 5

10 years ago
Not working on this anytime soon, please feel free to take.
Assignee: nth10sd → nobody
Status: ASSIGNED → NEW
Confirmed on Windows XP too using Thunderbird 3.0b3pre (20090226) + Lightning 1.0pre (20090228).
OS: Mac OS X → All
Bug 456385 reorganizes the menus, adding dependency.
Depends on: 456385
This seems to have been fixed by the checkin for bug 456385. Gary, please reopen if you're still seeing this.
Assignee: nobody → philipp
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
Version: Trunk → unspecified
Flags: tb-integration?
Hardware: x86 → All
Target Milestone: --- → 1.0
Status: RESOLVED → VERIFIED
(Assignee)

Comment 9

8 years ago
These bugs are likely targeted at Lightning 1.0b1, not Lightning 1.0. If this change was done in error, please adjust the target milestone to its correct value. To filter on this bugspam, you can use "lightning-10-target-move".
Target Milestone: 1.0 → 1.0b1
You need to log in before you can comment on or make changes to this bug.