466222 - update hg_helper.py on hg.m.o to know that '.' and '/' are valid characters in repository names

Status: RESOLVED FIXED

(mozilla.org Graveyard :: Server Operations, task)

Description

[[e-mail] (:bhearsum)]

Attachment: update hg_helper.py hook

The interactive cloning seems to bypass the name validation, but it is currently impossible to clone releases/mozilla-1.9.1 to a user repository via the 'ssh hg.m.o clone mymoz releases/mozilla-1.9.1' both because of the '/' and the '.'.

I don't think this could be a security risk - neither of these are special characters.

Comment 1

[[e-mail] (:bhearsum)]

any update here?

Comment 2

[Aravind Gottipati [:aravind]]

I will work on updating the script this week.  Should probably be ready sometime next week or so.

Comment 3

[[e-mail] (:bhearsum)]

Is the patch which I attached not enough?

Comment 4

[Aravind Gottipati [:aravind]]

I haven't had a chance to look at it.  Will do this week and integrate it into the script we have running.  Also the current script is different from the prev version + your previous patches, so your patches may be all be applicable.

Comment 5

[Aravind Gottipati [:aravind]]

I am not sure this is valid.  I was able to clone it exactly the way you described above.  Here is the output from my session.

~ $ssh hg.mozilla.org clone mymoz releases/mozilla-1.9.1
Cloning /releases/mozilla-1.9.1 to /users/aravind_mozilla.com/mymoz
(wait about 8 minutes..)
Clone complete.
Fixing permissions
(wait a few more minutes..)
~ $

What the check_repo does is prevent users from naming their repos with a . and / in it.  Otherwise things should be working correctly already.  Am I missing the point of this bug?  Did you want me to allow the . and / characters in user repos?

Comment 6

[[e-mail] (:bhearsum)]

Hm, good point!

Unless there's a reason not to it would be nice to allow '.' in user repository names, though.

Comment 7

[Aravind Gottipati [:aravind]]

Okay, will figure out a way to allow that, should be done sometime today.

Comment 8

[Aravind Gottipati [:aravind]]

Done, you can now have a repo with a . in the name.

Comment 9

[Justin Wood (:Callek)]

Probably even more trivial than this bug was about, but does this allow:
/^\.[a-zA-Z\.]/ as a repo name (yea regex, if you want 'english' I can too)

The problem I see is pending how we serve up the info here, it may hide the repo from the public or even make it less discoverable for IT if they ever need to touch-up stuff there...  (I'm not sure if it is a problem in practice basically)

Comment 10

[Aravind Gottipati [:aravind]]

(In reply to comment #9)
> Probably even more trivial than this bug was about, but does this allow:
> /^\.[a-zA-Z\.]/ as a repo name (yea regex, if you want 'english' I can too)

Actually, it shouldn't allow that.  Here is the regex that checks a user repos name.

def check_repo_name (repo_name):
    good_chars = re.compile ('^(\w|-|\w\.\w)+$')
    if not good_chars.search (repo_name):
        sys.stderr.write ('Only alpha-numeric characters, ".", and "-" are allowed in the repository names.\n')
        sys.stderr.write ('Please try again with only those characters.\n')
        sys.exit (1)
    return 1

Comment 11

[[e-mail] (:bhearsum)]

Looks like this never got fixed.

bitters-2:tmp bhearsum$ ssh hg.mozilla.org clone mozilla-1.9.1 releases/mozilla-1.9.1
Only alpha-numeric characters, ".", and "-" are allowed in the repository names.
Please try again with only those characters.

Comment 12

[Aravind Gottipati [:aravind]]

The regex wasn't permissive enough.  I changed it to

def check_repo_name (repo_name):
    good_chars = re.compile ('^(\w|-|.\w)+$')
    if not good_chars.search (repo_name):
        sys.stderr.write ('Only alpha-numeric characters, ".", and "-" are allowed in the repository names.\n')
        sys.stderr.write ('Please try again with only those characters.\n')
        sys.exit (1)
    return 1

Seems to be working now.

Comment 13

[Aravind Gottipati [:aravind]]

oops, I meant good_chars = re.compile ('^(\w|-|\.\w)+$')